Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of GCS refactoring #7198

Merged
merged 13 commits into from
Jul 29, 2024
Merged

Backport of GCS refactoring #7198

merged 13 commits into from
Jul 29, 2024

Conversation

nicholaspcr
Copy link
Contributor

Summary

OS counterpart of https://github.com/TheThingsIndustries/lorawan-stack/pull/4310

Changes

  • Deprecate DCS authorizeGateway and UnauthorizeGateway
  • Remove authorize and unauthorize CLI sub-commands
  • Update tests everywhere and improve code coverage.
  • Introduce clean gateway claiming flow that only creates gateways.

Testing

Steps

For this OS PR the only tests performed are the unite tests, no manual testing yet.

Regressions

Notes for Reviewers

This is a backport of a PR done in https://github.com/TheThingsIndustries/lorawan-stack/pull/4310

I went over each file, double checking the contents but its worth having a second read by someone else.

@KrishnaIyer this backport was done by @johanstokking's request in the hopes it alleviates your workload.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@nicholaspcr nicholaspcr added this to the v3.32.0 milestone Jul 29, 2024
@nicholaspcr nicholaspcr self-assigned this Jul 29, 2024
@github-actions github-actions bot added ui/cli This is related to ttn-lw-cli compat/config This could affect Configuration compatibility labels Jul 29, 2024
@nicholaspcr nicholaspcr force-pushed the feature/4301-gcs-refactoring branch 2 times, most recently from dd785c0 to 3709649 Compare July 29, 2024 02:07
@github-actions github-actions bot added the ui/web This is related to a web interface label Jul 29, 2024
@nicholaspcr nicholaspcr force-pushed the feature/4301-gcs-refactoring branch from 3709649 to 946fb12 Compare July 29, 2024 02:11
@KrishnaIyer
Copy link
Member

KrishnaIyer commented Jul 29, 2024

Thanks I'll pick this (for review I mean)

Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few comments.

  • Please also backport the observability changes for unclaiming.

@nicholaspcr nicholaspcr force-pushed the feature/4301-gcs-refactoring branch from 946fb12 to 795f771 Compare July 29, 2024 11:10
@nicholaspcr nicholaspcr marked this pull request as ready for review July 29, 2024 11:32
@nicholaspcr nicholaspcr requested review from a team as code owners July 29, 2024 11:32
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix CI, merge and do a merge to enterprise.

@nicholaspcr nicholaspcr force-pushed the feature/4301-gcs-refactoring branch from 795f771 to 08fbacd Compare July 29, 2024 12:10
@nicholaspcr nicholaspcr merged commit 460a9ce into v3.31 Jul 29, 2024
15 of 16 checks passed
@nicholaspcr nicholaspcr deleted the feature/4301-gcs-refactoring branch July 29, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat/config This could affect Configuration compatibility ui/cli This is related to ttn-lw-cli ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants