-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of GCS refactoring #7198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd785c0
to
3709649
Compare
3709649
to
946fb12
Compare
Thanks I'll pick this (for review I mean) |
7 tasks
KrishnaIyer
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few comments.
- Please also backport the observability changes for unclaiming.
946fb12
to
795f771
Compare
KrishnaIyer
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please fix CI, merge and do a merge to enterprise.
795f771
to
08fbacd
Compare
johanstokking
approved these changes
Jul 29, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compat/config
This could affect Configuration compatibility
ui/cli
This is related to ttn-lw-cli
ui/web
This is related to a web interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OS counterpart of https://github.com/TheThingsIndustries/lorawan-stack/pull/4310
Changes
authorizeGateway
andUnauthorizeGateway
authorize
andunauthorize
CLI sub-commandsTesting
Steps
For this OS PR the only tests performed are the unite tests, no manual testing yet.
Regressions
Notes for Reviewers
This is a backport of a PR done in https://github.com/TheThingsIndustries/lorawan-stack/pull/4310
I went over each file, double checking the contents but its worth having a second read by someone else.
@KrishnaIyer this backport was done by @johanstokking's request in the hopes it alleviates your workload.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.