Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed gateway groundwork #7181

Merged
merged 63 commits into from
Jul 31, 2024
Merged

Managed gateway groundwork #7181

merged 63 commits into from
Jul 31, 2024

Conversation

johanstokking
Copy link
Member

@johanstokking johanstokking commented Jul 9, 2024

Summary

References https://github.com/TheThingsIndustries/lorawan-stack/issues/4256
Groundwork for #7178

This adds groundwork for managed gateways in The Things Stack.

Changes

  • Add groundwork for TTI gateway protocol as GS frontend
  • Add The Things Gateway Controller client and integration in Gateway Configuration Server
  • Add events multiplexer to add additional event streams, in this case managed gateway events that come from The Things Gateway Controller
  • Add missing checks for gateway tokens
  • Resolve some technical debt, including but not limited to
    • Existing WebSocket listeners in GS
    • Lint warnings
    • Obsolete settings
    • Structure of GCS
    • Missing GS IO test cases and values (suppressed for UDP and LBS LNS that have limited support for this)

Testing

Testing of this PR is mostly through unit tests and tedious manual tests with WebSockets and TTS API calls.

Testing steps for QA sign off will be part of #7178.

Notes for Reviewers

@KrishnaIyer is the main reviewer.

This is draft until:

  • Testing section is filled out
  • GS frontend is implemented and tested
  • More integration testing is done
  • Commit trail is clean
  • Infrastructure PR is (almost) ready
  • Changelog is updated
  • CI pass

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking added this to the v3.31.1 milestone Jul 9, 2024
@johanstokking johanstokking self-assigned this Jul 9, 2024
@johanstokking johanstokking requested review from a team as code owners July 9, 2024 13:42
@github-actions github-actions bot added c/gateway server This is related to the Gateway Server compat/db This could affect Database compatibility c/gateway conf server This is related to the Gateway Configuration Server dependencies Pull requests that update a dependency file ui/web This is related to a web interface tooling Development tooling compat/config This could affect Configuration compatibility labels Jul 9, 2024
@johanstokking johanstokking marked this pull request as draft July 9, 2024 13:43
@johanstokking johanstokking removed the request for review from ryaplots July 9, 2024 13:43
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed API, GCS and the events mux. Looks good to me.

@johanstokking johanstokking force-pushed the feature/tti-gtw-lorapf branch from 3f08f48 to 049786b Compare July 12, 2024 12:29
@happyRip happyRip modified the milestones: v3.31.1, v3.32.0 Jul 17, 2024
@johanstokking johanstokking force-pushed the feature/tti-gtw-lorapf branch from c6380f4 to 7efbe37 Compare July 23, 2024 09:37
@github-actions github-actions bot added the c/identity server This is related to the Identity Server label Jul 23, 2024
@johanstokking johanstokking force-pushed the feature/tti-gtw-lorapf branch 4 times, most recently from 96cc713 to 9ed9db5 Compare July 26, 2024 09:56
…ctions

The Gateway Controller is only available as hosted service operated by
The Things Industries.
Port 1888 is used by a proprietary frontend.
@johanstokking johanstokking force-pushed the feature/tti-gtw-lorapf branch from 55fc7db to 1e9c11f Compare July 29, 2024 21:03
@KrishnaIyer KrishnaIyer changed the base branch from v3.31 to v3.32 July 30, 2024 08:26
@johanstokking johanstokking merged commit 8fd6e1a into v3.32 Jul 31, 2024
11 of 13 checks passed
@johanstokking johanstokking deleted the feature/tti-gtw-lorapf branch July 31, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway conf server This is related to the Gateway Configuration Server c/gateway server This is related to the Gateway Server c/identity server This is related to the Identity Server compat/config This could affect Configuration compatibility compat/db This could affect Database compatibility dependencies Pull requests that update a dependency file tooling Development tooling ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants