Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rate limit key ws to semtechws/lbslns #7119

Merged
merged 3 commits into from
May 31, 2024
Merged

Conversation

johanstokking
Copy link
Member

Summary

Follow up on #7110

Changes

This renames the ws ratelimit key to semtechws/lbslns.

Testing

Steps

N/A

Results

N/A

Regressions

This is a config changes. If there is custom rate limit config, there has to be an adjustment made. This is unfortunate but ws is just not a good key for Basic Station.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking added this to the v3.31.0 milestone May 31, 2024
@johanstokking johanstokking requested a review from KrishnaIyer May 31, 2024 12:57
@johanstokking johanstokking self-assigned this May 31, 2024
@johanstokking johanstokking requested a review from a team as a code owner May 31, 2024 12:57
@github-actions github-actions bot added the c/gateway server This is related to the Gateway Server label May 31, 2024
@johanstokking johanstokking changed the title Rename rate limit key to ws to semtechws/lbslns Rename rate limit key ws to semtechws/lbslns May 31, 2024
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok I think.

@johanstokking johanstokking merged commit 4e4483f into v3.31 May 31, 2024
11 of 13 checks passed
@johanstokking johanstokking deleted the feature/semtechws branch May 31, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway server This is related to the Gateway Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants