-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest decoded payload panel #7118
Merged
kschiffer
merged 12 commits into
feature/console-redesign
from
feature/latest-decoded-payload-panel
Jun 17, 2024
Merged
Latest decoded payload panel #7118
kschiffer
merged 12 commits into
feature/console-redesign
from
feature/latest-decoded-payload-panel
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiffer
suggested changes
Jun 4, 2024
pkg/webui/console/containers/latest-decoded-payload-panel/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/latest-decoded-payload-panel/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/latest-decoded-payload-panel/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/latest-decoded-payload-panel/latest-decoded-payload-panel.styl
Outdated
Show resolved
Hide resolved
ee41017
to
a52311e
Compare
325a14d
to
d9da16d
Compare
@kschiffer I applied the changes we talked about in the sync. Please check if you have any suggestions/improvements 😄 |
9888f69
to
0a8b9eb
Compare
0a8b9eb
to
f537daf
Compare
kschiffer
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement latest decoded payload panel.
Changes
Added latest decoded panel in application overview.
Testing
Steps
Results
Notes for Reviewers
I left the
react-ace
code editor component because when I was investigating other options, seems like there was no lightweight component that satisfies all our scenarios and needs.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.