From 034ebac11814d7a5fea2d9a33e6e3a0576f6690e Mon Sep 17 00:00:00 2001 From: Pavel Jankoski Date: Fri, 31 May 2024 12:37:02 +0200 Subject: [PATCH] console: Fix console errors when fetching status summary --- pkg/webui/lib/store/logics/status.js | 4 ++++ pkg/webui/lib/store/reducers/status.js | 16 +++++++++------- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/pkg/webui/lib/store/logics/status.js b/pkg/webui/lib/store/logics/status.js index c626783b26..f24ea75eec 100644 --- a/pkg/webui/lib/store/logics/status.js +++ b/pkg/webui/lib/store/logics/status.js @@ -22,6 +22,7 @@ import { isNetworkError, isTimeoutError } from '@ttn-lw/lib/errors/utils' import * as status from '@ttn-lw/lib/store/actions/status' import { selectIsOfflineStatus } from '@ttn-lw/lib/store/selectors/status' import createRequestLogic from '@ttn-lw/lib/store/logics/create-request-logic' +import { initialSummaryState } from '@ttn-lw/lib/store/reducers/status' const probeUrl = `${selectIsConfig().base_url}/auth_info` @@ -120,6 +121,9 @@ const getNetworkStatusSummaryLogic = createRequestLogic({ type: status.GET_NETWORK_STATUS_SUMMARY, process: async () => { const baseUrl = selectPageStatusBaseUrlConfig() + if (!baseUrl?.trim()) { + return { summary: initialSummaryState } + } const response = await axios.get(`${baseUrl}/api/v2/summary.json`, { headers: { diff --git a/pkg/webui/lib/store/reducers/status.js b/pkg/webui/lib/store/reducers/status.js index 1d4a7f159c..086fd8bb2c 100644 --- a/pkg/webui/lib/store/reducers/status.js +++ b/pkg/webui/lib/store/reducers/status.js @@ -20,16 +20,18 @@ import { GET_NETWORK_STATUS_SUMMARY_SUCCESS, } from '@ttn-lw/lib/store/actions/status' +export const initialSummaryState = { + scheduled_maintenances: [], + status: { + indicator: 'none', + description: '', + }, +} + const defaultState = { onlineStatus: ONLINE_STATUS.ONLINE, isLoginRequired: false, - summary: { - scheduled_maintenances: [], - status: { - indicator: 'none', - description: '', - }, - }, + summary: initialSummaryState, } const status = (state = defaultState, { type, payload }) => {