Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway status panel #7104

Merged
merged 28 commits into from
Jun 7, 2024

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented May 27, 2024

Summary

This PR adds the gateway status panel

Changes

  • Add apexcharts
  • Add panel
  • Fix general styling

Testing

Steps

Log into the console in staging
Go to several gateways to seen different states of the panel

Results
Screenshot 2024-05-27 at 16 15 50 Screenshot 2024-05-27 at 16 57 52 Screenshot 2024-05-27 at 17 02 50
Regressions

...

Notes for Reviewers

This is how the responsiveness looks currently. I think this looks too crammed, and long in height. Should we consider separating the information into several panels?
Also, for this I cannot rely on our screen breakpoints, because there is a medium screen where the panels are in a 2/2 grid, and need to have the responsiveness applied, but then right after, on an even smaller screen the panels are already in a 1/1 grid and there they don't need the responsiveness. So I am using container media queries. We should define container breakpoints, because right now I am using the width of the moment the layout breaks.

Screenshot 2024-05-28 at 10 12 56 Screenshot 2024-05-28 at 10 01 10

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label May 27, 2024
@ryaplots ryaplots added this to the 2024 Q1 milestone May 27, 2024
@ryaplots ryaplots self-assigned this May 27, 2024
@ryaplots ryaplots force-pushed the feature/gateway-status-panel branch from 8c0d373 to 3fcfc95 Compare May 30, 2024 07:05
@ryaplots ryaplots marked this pull request as ready for review May 30, 2024 13:10
@ryaplots ryaplots requested a review from a team as a code owner May 30, 2024 13:10
Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Please check this:
image
The roundtrip times bar is missing here for kerlink-ibts-compact-1.

Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@ryaplots ryaplots requested a review from kschiffer June 4, 2024 12:44
@ryaplots ryaplots merged commit 2a40ccb into feature/console-redesign Jun 7, 2024
6 checks passed
@ryaplots ryaplots deleted the feature/gateway-status-panel branch June 7, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants