-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gateway status panel #7104
Merged
ryaplots
merged 28 commits into
feature/console-redesign
from
feature/gateway-status-panel
Jun 7, 2024
Merged
Add gateway status panel #7104
ryaplots
merged 28 commits into
feature/console-redesign
from
feature/gateway-status-panel
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c0d373
to
3fcfc95
Compare
kschiffer
suggested changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkg/webui/console/containers/gateway-status-panel/transmissions.js
Outdated
Show resolved
Hide resolved
kschiffer
suggested changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
kschiffer
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the gateway status panel
Changes
Testing
Steps
Log into the console in staging
Go to several gateways to seen different states of the panel
Results
Regressions
...
Notes for Reviewers
This is how the responsiveness looks currently. I think this looks too crammed, and long in height. Should we consider separating the information into several panels?
Also, for this I cannot rely on our screen breakpoints, because there is a medium screen where the panels are in a 2/2 grid, and need to have the responsiveness applied, but then right after, on an even smaller screen the panels are already in a 1/1 grid and there they don't need the responsiveness. So I am using container media queries. We should define container breakpoints, because right now I am using the width of the moment the layout breaks.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.