Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various console redesign fixes #7100

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Conversation

ryaplots
Copy link
Contributor

Summary

This PR applies various fixes to the console redesign.

Changes

  • Fix browser console warnings and errors
  • Fix top entities panel responsiveness
Screenshot 2024-05-24 at 16 28 24 Screenshot 2024-05-24 at 16 28 36

Testing

Steps
  • Run the console
  • Resize the window to see the top entities panel responsive
  • open browser console and see no errors

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots self-assigned this May 24, 2024
@ryaplots ryaplots requested a review from a team as a code owner May 24, 2024 14:32
@ryaplots ryaplots requested review from kschiffer and removed request for a team May 24, 2024 14:32
@github-actions github-actions bot added the ui/web This is related to a web interface label May 24, 2024
@ryaplots ryaplots requested a review from PavelJankoski May 27, 2024 07:42
@ryaplots ryaplots force-pushed the fix/console-fixes branch from 217c613 to 53738d0 Compare May 31, 2024 08:39
@ryaplots ryaplots requested a review from kschiffer June 3, 2024 09:39
@ryaplots ryaplots requested a review from kschiffer June 5, 2024 14:49
@ryaplots ryaplots force-pushed the fix/console-fixes branch 2 times, most recently from a244f8b to 13a7d2c Compare June 7, 2024 13:16
@kschiffer kschiffer force-pushed the fix/console-fixes branch from 13a7d2c to 4805445 Compare June 11, 2024 15:02
@kschiffer kschiffer force-pushed the fix/console-fixes branch from 4805445 to f4f559a Compare June 11, 2024 15:28
@kschiffer kschiffer merged commit 421dbf6 into feature/console-redesign Jun 11, 2024
7 of 12 checks passed
@kschiffer kschiffer deleted the fix/console-fixes branch June 11, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants