Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListEndDevicesRequest rate limiting key #7085

Merged
merged 1 commit into from
May 16, 2024

Conversation

adriansmares
Copy link
Contributor

Summary

Fixes https://the-things-industries.sentry.io/issues/5359002052

Changes

  • Add EntityType / IDString / ExtractRequestFields to ListEndDevicesRequest in order to make it be rate limited on a per application basis instead of globally.

Testing

Steps

N/A.

Results

N/A.

Regressions

In short, this will allow more ListEndDevicesRequest calls to be done in parallel as now they are rate limited on a per application basis, but that should be fine and was the originally intended use anyway.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the bug Something isn't working label May 16, 2024
@adriansmares adriansmares added this to the v3.30.2 milestone May 16, 2024
@adriansmares adriansmares self-assigned this May 16, 2024
@adriansmares adriansmares requested a review from KrishnaIyer May 16, 2024 12:33
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup 👍

@adriansmares adriansmares marked this pull request as ready for review May 16, 2024 12:43
@adriansmares adriansmares requested a review from a team as a code owner May 16, 2024 12:43
@adriansmares adriansmares merged commit 97bf178 into v3.30 May 16, 2024
12 of 13 checks passed
@adriansmares adriansmares deleted the fix/list-end-devices-key branch May 16, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants