Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redux store setup #7083

Merged
merged 1 commit into from
May 22, 2024
Merged

Update redux store setup #7083

merged 1 commit into from
May 22, 2024

Conversation

kschiffer
Copy link
Contributor

Summary

This quickfix PR updates the store setup to remove deprecated logic and modules.

Changes

  • Update Console store setup
  • Update Account app store setup
  • Remove redux-sentry-middleware
  • Replace @sentry/browser with @sentry/react

Testing

This is purely a logic change with no implications for the end user.

Notes for Reviewers

This will fix this issue:
image

The reason being that redux-sentry-middleware uses a now removed configureScope() hook. Sentry has now a native way to integrate with redux, which is what this refactor sets up.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added c/console This is related to the Console ui/web This is related to a web interface labels May 16, 2024
@kschiffer kschiffer added this to the v3.30.1 milestone May 16, 2024
@kschiffer kschiffer self-assigned this May 16, 2024
@kschiffer kschiffer requested a review from a team as a code owner May 16, 2024 11:50
@kschiffer kschiffer requested a review from PavelJankoski May 16, 2024 11:50
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 16, 2024
Copy link
Contributor

@PavelJankoski PavelJankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to backport these changes to ENT as well.

Copy link
Contributor

@PavelJankoski PavelJankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this again with staging env configuration locally and the problem seems to persist. But this may be due that I am redirected to https://tti.staging1.cloud.thethings.industries/oauth/login and the changes are not yet applied. Please verify this.

image

@kschiffer
Copy link
Contributor Author

Oh, so yeah, when you connect your local console with staging then you still need to use the staging console to authenticate. This is why the error still persists there, until we've updated the snapshot with this fix.

@kschiffer kschiffer requested a review from PavelJankoski May 22, 2024 09:32
@kschiffer kschiffer force-pushed the fix/sentry-redux-fix branch from 8a642b9 to 470b81b Compare May 22, 2024 09:55
@kschiffer kschiffer merged commit d8bd297 into v3.30 May 22, 2024
12 of 13 checks passed
@kschiffer kschiffer deleted the fix/sentry-redux-fix branch May 22, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console dependencies Pull requests that update a dependency file ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants