Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://the-things-industries.sentry.io/issues/5353455597
This PR makes the filtering of packets to be 'linear' for the same source address. This means that different source addresses are evaluated in parallel, but individual addresses (so gateways) are evaluated serially.
Changes
Testing
Steps
This change has been tested on
staging1
and other environments. As this is mainly technical debt and performance improvements, there are no manual testing steps to be done.Results
Errors such as
Failed to store updated rate limit data for key gs:up:udp:addr:x.x.x.x:y after 10 attempts
are no longer encountered.Regressions
N/A.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.