Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade throttled usage #7080

Merged
merged 5 commits into from
May 15, 2024
Merged

Upgrade throttled usage #7080

merged 5 commits into from
May 15, 2024

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented May 15, 2024

Summary

References https://github.com/TheThingsIndustries/lorawan-stack/pull/2757

This PR upgrades our use of throttled to use the new context based interface, along with some bugs.

Changes

  • Use context based interface while doing throttled calls.
  • Fix error logging to actually include the error which occurred.
  • Fix gRPC stream key.
  • Use arrival time adjusted timestamps for gateway -> Application Server latency.
  • Backport UDP rate limiting key change.

Testing

Steps

The changes here are lots of debt but not so much semantics. They have been tested on staging1 and other deployments and should be evaluated as code.

Results

N/A.

Regressions

N/A.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.30.2 milestone May 15, 2024
@adriansmares adriansmares self-assigned this May 15, 2024
@github-actions github-actions bot added the c/application server This is related to the Application Server label May 15, 2024
@adriansmares adriansmares added the technical debt Not necessarily broken, but could be done better/cleaner label May 15, 2024
@adriansmares adriansmares marked this pull request as ready for review May 15, 2024 10:53
@adriansmares adriansmares requested review from a team as code owners May 15, 2024 10:53
@adriansmares adriansmares merged commit 2457908 into v3.30 May 15, 2024
13 checks passed
@adriansmares adriansmares deleted the feature/upgrade-throttled-usage branch May 15, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/application server This is related to the Application Server technical debt Not necessarily broken, but could be done better/cleaner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants