Merge v3.30 into console-redesign

.github/PULL_REQUEST_TEMPLATE.md

@@ -23,6 +23,8 @@ Typically, issues should be closed manually after validation.
 
 #### Testing
 
+##### Steps
+
 <!--
 Explain the detailed steps to test this feature.
 Please note that these steps may be used by others to test this feature.
@@ -31,6 +33,12 @@ Describe pre-requisites and/or assumptions made about the testing environment.
 
 ...
 
+##### Results
+
+<!--
+Please add screenshots, command outputs, and/or relevant screen captures of the tests.
+-->
+
 ##### Regressions
 
 <!--

.github/workflows/go.yml

@@ -40,12 +40,10 @@ jobs:
       - name: Check for diff
         run: tools/bin/mage git:diff
       - name: Lint code
-        uses: golangci/golangci-lint-action@v4
+        uses: golangci/golangci-lint-action@v5
         with:
-          version: v1.56.2
+          version: v1.57.2
           only-new-issues: true
-          skip-pkg-cache: true # Caching is set up by install-go-and-deps
-          skip-build-cache: true # Caching is set up by install-go-and-deps
           args: --timeout=10m ./pkg/... ./cmd/...
 
   test:

CHANGELOG.md

@@ -19,14 +19,16 @@ For details about compatibility between different releases, see the **Commitment
 
 ### Fixed
 
+- Increased the timeout for Basic Station gateways sending HTTP headers. There should now be enough time for embedded devices with little to no hardware acceleration to perform a TLS handshake. In particular, The Things Indoor Gateway can now connect to The Things Stack presenting a ECDSA certificate.
+
 ### Security
 
 ## [3.30.1] - unreleased
 
 ### Added
 
 - Support fine-grained NbTrans controls while using Dynamic ADR mode in the Console.
-- User bookmark listing now supports filtering bookmarks by entity type. 
+- User bookmark listing now supports filtering bookmarks by entity type.
   - This can be specified by setting `entity_types` field in `ListUserBookmarksRequest`.
 
 ### Fixed

api/ttn/lorawan/v3/api.md

@@ -8183,6 +8183,7 @@ Application uplink message.
 | `last_a_f_cnt_down` | [`uint32`](#uint32) |  | The last AFCntDown of the current session. This field is only present if the skip_payload_crypto field of the EndDevice is true. Can be used with app_s_key to encrypt downlink payloads. |
 | `confirmed` | [`bool`](#bool) |  | Indicates whether the end device used confirmed data uplink. |
 | `consumed_airtime` | [`google.protobuf.Duration`](#google.protobuf.Duration) |  | Consumed airtime for the transmission of the uplink message. Calculated by Network Server using the raw payload size and the transmission settings. |
+| `packet_error_rate` | [`float`](#float) |  | Packet error rate of the recent uplinks in the current session. Calculated by the Network Server. The value is defined in the [0, 1] interval. |
 | `locations` | [`ApplicationUplink.LocationsEntry`](#ttn.lorawan.v3.ApplicationUplink.LocationsEntry) | repeated | End device location metadata, set by the Application Server while handling the message. |
 | `version_ids` | [`EndDeviceVersionIdentifiers`](#ttn.lorawan.v3.EndDeviceVersionIdentifiers) |  | End device version identifiers, set by the Application Server while handling the message. |
 | `network_ids` | [`NetworkIdentifiers`](#ttn.lorawan.v3.NetworkIdentifiers) |  | Network identifiers, set by the Network Server that handles the message. |
@@ -11174,7 +11175,7 @@ API keys of users.
 
 | Method Name | Method | Pattern | Body |
 | ----------- | ------ | ------- | ---- |
-| `Create` | `POST` | `/api/v3/users/bookmarks` | `*` |
+| `Create` | `POST` | `/api/v3/users/{user_ids.user_id}/bookmarks` | `*` |
 | `List` | `GET` | `/api/v3/users/{user_ids.user_id}/bookmarks` |  |
 | `Delete` | `DELETE` | `/api/v3/users/{user_ids.user_id}/bookmarks/applications/{entity_ids.application_ids.application_id}` |  |
 | `Delete` | `DELETE` | `/api/v3/users/{user_ids.user_id}/bookmarks/clients/{entity_ids.client_ids.client_id}` |  |

api/ttn/lorawan/v3/api.swagger.json

@@ -12704,39 +12704,6 @@
         ]
       }
     },
-    "/users/bookmarks": {
-      "post": {
-        "summary": "Create a bookmark for the given user.",
-        "operationId": "UserBookmarkRegistry_Create",
-        "responses": {
-          "200": {
-            "description": "A successful response.",
-            "schema": {
-              "$ref": "#/definitions/v3UserBookmark"
-            }
-          },
-          "default": {
-            "description": "An unexpected error response.",
-            "schema": {
-              "$ref": "#/definitions/googlerpcStatus"
-            }
-          }
-        },
-        "parameters": [
-          {
-            "name": "body",
-            "in": "body",
-            "required": true,
-            "schema": {
-              "$ref": "#/definitions/v3CreateUserBookmarkRequest"
-            }
-          }
-        ],
-        "tags": [
-          "UserBookmarkRegistry"
-        ]
-      }
-    },
     "/users/{collaborator.user_ids.user_id}/applications": {
       "get": {
         "summary": "List applications where the given user or organization is a direct collaborator.\nIf no user or organization is given, this returns the applications the caller\nhas access to.\nSimilar to Get, this selects the fields given by the field mask.\nMore or less fields may be returned, depending on the rights of the caller.",
@@ -13960,6 +13927,44 @@
         "tags": [
           "UserBookmarkRegistry"
         ]
+      },
+      "post": {
+        "summary": "Create a bookmark for the given user.",
+        "operationId": "UserBookmarkRegistry_Create",
+        "responses": {
+          "200": {
+            "description": "A successful response.",
+            "schema": {
+              "$ref": "#/definitions/v3UserBookmark"
+            }
+          },
+          "default": {
+            "description": "An unexpected error response.",
+            "schema": {
+              "$ref": "#/definitions/googlerpcStatus"
+            }
+          }
+        },
+        "parameters": [
+          {
+            "name": "user_ids.user_id",
+            "description": "This ID shares namespace with organization IDs.",
+            "in": "path",
+            "required": true,
+            "type": "string"
+          },
+          {
+            "name": "body",
+            "in": "body",
+            "required": true,
+            "schema": {
+              "$ref": "#/definitions/v3UserBookmarkRegistryCreateBody"
+            }
+          }
+        ],
+        "tags": [
+          "UserBookmarkRegistry"
+        ]
       }
     },
     "/users/{user_ids.user_id}/bookmarks/applications/{entity_ids.application_ids.application_id}": {
@@ -19396,6 +19401,11 @@
           "type": "string",
           "description": "Consumed airtime for the transmission of the uplink message. Calculated by Network Server using the raw payload size and the transmission settings."
         },
+        "packet_error_rate": {
+          "type": "number",
+          "format": "float",
+          "description": "Packet error rate of the recent uplinks in the current session.\nCalculated by the Network Server. The value is defined in the [0, 1] interval."
+        },
         "locations": {
           "type": "object",
           "additionalProperties": {
@@ -21008,17 +21018,6 @@
         }
       }
     },
-    "v3CreateUserBookmarkRequest": {
-      "type": "object",
-      "properties": {
-        "user_ids": {
-          "$ref": "#/definitions/v3UserIdentifiers"
-        },
-        "entity_ids": {
-          "$ref": "#/definitions/v3EntityIdentifiers"
-        }
-      }
-    },
     "v3CreateUserRequest": {
       "type": "object",
       "properties": {
@@ -27269,6 +27268,23 @@
         }
       }
     },
+    "v3UserBookmarkRegistryCreateBody": {
+      "type": "object",
+      "properties": {
+        "user_ids": {
+          "type": "object",
+          "properties": {
+            "email": {
+              "type": "string",
+              "description": "Secondary identifier, which can only be used in specific requests."
+            }
+          }
+        },
+        "entity_ids": {
+          "$ref": "#/definitions/v3EntityIdentifiers"
+        }
+      }
+    },
     "v3UserBookmarks": {
       "type": "object",
       "properties": {

api/ttn/lorawan/v3/messages.proto

@@ -246,6 +246,10 @@ message ApplicationUplink {
   // Consumed airtime for the transmission of the uplink message. Calculated by Network Server using the raw payload size and the transmission settings.
   google.protobuf.Duration consumed_airtime = 13;
 
+  // Packet error rate of the recent uplinks in the current session.
+  // Calculated by the Network Server. The value is defined in the [0, 1] interval.
+  float packet_error_rate = 19;
+
   // End device location metadata, set by the Application Server while handling the message.
   map<string, Location> locations = 14;
 
@@ -255,7 +259,7 @@ message ApplicationUplink {
   // Network identifiers, set by the Network Server that handles the message.
   NetworkIdentifiers network_ids = 16;
 
-  // next: 19
+  // next: 20
 }
 
 message ApplicationUplinkNormalized {

api/ttn/lorawan/v3/user_services.proto

@@ -182,7 +182,7 @@ service UserBookmarkRegistry {
   // Create a bookmark for the given user.
   rpc Create(CreateUserBookmarkRequest) returns (UserBookmark) {
     option (google.api.http) = {
-      post: "/users/bookmarks"
+      post: "/users/{user_ids.user_id}/bookmarks"
       body: "*"
     };
   }

go.mod

@@ -12,7 +12,7 @@ require (
 	github.com/TheThingsIndustries/protoc-gen-go-flags v1.2.0
 	github.com/TheThingsIndustries/protoc-gen-go-json v1.6.0
 	github.com/TheThingsNetwork/go-cayenne-lib v1.2.0
-	github.com/aws/aws-sdk-go v1.51.26
+	github.com/aws/aws-sdk-go v1.51.31
 	github.com/blang/semver v3.5.1+incompatible
 	github.com/blevesearch/bleve v1.0.14
 	github.com/bluele/gcache v0.0.2
@@ -36,7 +36,7 @@ require (
 	github.com/gotnospirit/messageformat v0.0.0-20221001023931-dfe49f1eb092
 	github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79
 	github.com/grpc-ecosystem/go-grpc-middleware v1.4.0
-	github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus v1.0.0
+	github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus v1.0.1
 	github.com/grpc-ecosystem/grpc-gateway/v2 v2.19.1
 	github.com/hellofresh/health-go/v5 v5.5.3
 	github.com/howeyc/gopass v0.0.0-20210920133722-c8aef6fb66ef
@@ -74,15 +74,15 @@ require (
 	github.com/uptrace/bun/dialect/pgdialect v1.2.1
 	github.com/uptrace/bun/driver/pgdriver v1.2.1
 	github.com/vmihailenco/msgpack/v5 v5.4.1
-	go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux v0.50.0
-	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.50.0
-	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.50.0
-	go.opentelemetry.io/otel v1.25.0
-	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.25.0
-	go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.25.0
-	go.opentelemetry.io/otel/metric v1.25.0
-	go.opentelemetry.io/otel/sdk v1.25.0
-	go.opentelemetry.io/otel/trace v1.25.0
+	go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux v0.51.0
+	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.51.0
+	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.51.0
+	go.opentelemetry.io/otel v1.26.0
+	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.26.0
+	go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.26.0
+	go.opentelemetry.io/otel/metric v1.26.0
+	go.opentelemetry.io/otel/sdk v1.26.0
+	go.opentelemetry.io/otel/trace v1.26.0
 	go.packetbroker.org/api/iam v1.8.2
 	go.packetbroker.org/api/iam/v2 v2.9.1
 	go.packetbroker.org/api/mapping/v2 v2.3.2
@@ -101,7 +101,7 @@ require (
 	golang.org/x/sync v0.7.0
 	google.golang.org/genproto v0.0.0-20240311173647-c811ad7063a7
 	google.golang.org/genproto/googleapis/api v0.0.0-20240311173647-c811ad7063a7
-	google.golang.org/genproto/googleapis/rpc v0.0.0-20240401170217-c3f982113cda
+	google.golang.org/genproto/googleapis/rpc v0.0.0-20240415180920-8c6c420018be
 	google.golang.org/grpc v1.63.2
 	google.golang.org/protobuf v1.33.0
 	gopkg.in/mail.v2 v2.3.1
@@ -185,7 +185,7 @@ require (
 	github.com/googleapis/enterprise-certificate-proxy v0.3.2 // indirect
 	github.com/googleapis/gax-go/v2 v2.12.2 // indirect
 	github.com/gotnospirit/makeplural v0.0.0-20180622080156-a5f48d94d976 // indirect
-	github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.0.0-rc.3 // indirect
+	github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.1.0 // indirect
 	github.com/hashicorp/golang-lru v0.5.4 // indirect
 	github.com/hashicorp/hcl v1.0.0 // indirect
 	github.com/huandu/xstrings v1.3.3 // indirect
@@ -240,8 +240,8 @@ require (
 	github.com/willf/bitset v1.1.10 // indirect
 	go.etcd.io/bbolt v1.3.5 // indirect
 	go.opencensus.io v0.24.0 // indirect
-	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.25.0 // indirect
-	go.opentelemetry.io/proto/otlp v1.1.0 // indirect
+	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.26.0 // indirect
+	go.opentelemetry.io/proto/otlp v1.2.0 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
 	golang.org/x/image v0.14.0 // indirect
 	golang.org/x/sys v0.19.0 // indirect