Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce stylus linting and various stylus updates/fixes #6933

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

kschiffer
Copy link
Contributor

Summary

This PR reintroduces linting for our stylus files and also updates the codebase accordingly.

Changes

  • Add stylelint and stylelint-stylus
  • Refactor stylus codebase to adhere to new rules
  • Some removal of unnecessary style definitions
  • Add stylus linting to CI
Regressions

I've removed the !important flags from all utility classes. This will likely cause layout issues. However, since this PR targets the redesign branch, I believe it's a good point in time to do this since we will touch most screens anyway and can either replace or fix these issues when we see them.

Notes for Reviewers

Best to use a stylelint linting plugin for your IDEs to see this issues before pushing.
Stylelint also has a --fix flag which works quite well most of the time. In vim I use this to automatically fix issues when I save.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added c/console This is related to the Console ui/web This is related to a web interface tooling Development tooling labels Feb 14, 2024
@kschiffer kschiffer self-assigned this Feb 14, 2024
@kschiffer kschiffer requested a review from a team as a code owner February 14, 2024 10:47
@kschiffer kschiffer requested review from a team, ryaplots and adriansmares February 14, 2024 10:47
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 14, 2024
Copy link
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! There's just some conflicts.

@kschiffer kschiffer requested a review from a team as a code owner February 19, 2024 07:43
@kschiffer kschiffer force-pushed the fix/styles-tooling branch 3 times, most recently from 6304edd to c0a0458 Compare February 19, 2024 11:10
@kschiffer kschiffer merged commit b73b32a into feature/console-redesign Feb 19, 2024
14 of 24 checks passed
@kschiffer kschiffer deleted the fix/styles-tooling branch February 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console dependencies Pull requests that update a dependency file tooling Development tooling ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants