Reintroduce stylus linting and various stylus updates/fixes #6933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reintroduces linting for our stylus files and also updates the codebase accordingly.
Changes
Regressions
I've removed the
!important
flags from all utility classes. This will likely cause layout issues. However, since this PR targets the redesign branch, I believe it's a good point in time to do this since we will touch most screens anyway and can either replace or fix these issues when we see them.Notes for Reviewers
Best to use a stylelint linting plugin for your IDEs to see this issues before pushing.
Stylelint also has a
--fix
flag which works quite well most of the time. In vim I use this to automatically fix issues when I save.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.