Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component duplicated and apply various fixes #6787

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

ryaplots
Copy link
Contributor

Summary

This PR integrates sidebar and header groundwork and removes component duplicates

Changes

  • Remove old button
  • Remove old dropdown
  • Remove old navigation
  • Remove old header
  • Apply various fixes to make this work correctly

Testing

  1. Run the console

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Dec 28, 2023
@ryaplots ryaplots self-assigned this Dec 28, 2023
@ryaplots ryaplots requested a review from a team as a code owner December 28, 2023 13:23
@ryaplots ryaplots requested review from kschiffer and removed request for a team December 28, 2023 13:23
@kschiffer
Copy link
Contributor

Let's merge this and I'll work on some adjustments in the sidebar branch directly.

@kschiffer kschiffer merged commit 3adafb2 into feature/new-sidebar Dec 29, 2023
5 of 12 checks passed
@kschiffer kschiffer deleted the feature/remove-duplicates branch December 29, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants