You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In a recent discussion with @mkosunen it was brought up that keyword arguments **kwargs should be preferred instead of using *args. This project still uses the *args for entity/controller initialization in at least the following locations:
This is kind of embarassing. I think this is the only occasion where I have done this, the first hack just to get it to work, and it just have not been changed. That first argument is supposed to be parent instance, if it is given.
But you are right, we should change it, and now we shoud figure out how to do it so that the change is backwards compatible and does not break every entity ever written for thesydekick :)
In a recent discussion with @mkosunen it was brought up that keyword arguments
**kwargs
should be preferred instead of using*args
. This project still uses the*args
for entity/controller initialization in at least the following locations:inverter/inverter/__init__.py
Line 51 in c848bb0
inverter/inverter/controller.py
Line 15 in fff15a8
The text was updated successfully, but these errors were encountered: