Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should know if PBSJobManager.updateJobStatus failed #26

Closed
askask opened this issue Jun 27, 2017 · 4 comments
Closed

User should know if PBSJobManager.updateJobStatus failed #26

askask opened this issue Jun 27, 2017 · 4 comments
Assignees

Comments

@askask
Copy link
Contributor

askask commented Jun 27, 2017

When I call one of the queryJobStatus* methods in PBSJobManager, and get back an empty map, I don't know whether no jobs are running anymore, or updateJobStatus/qstat failed.

@dankwart-de
Copy link
Contributor

see PR27 #27
Let's discuss if this is feasible

@dankwart-de dankwart-de self-assigned this Jun 27, 2017
@vinjana
Copy link
Contributor

vinjana commented Oct 4, 2017

The classical way to handle such situation in Java is via exceptions. So better throw an exception with a descriptive message and use appropriate exception classes expressing "qstat failed" and "job not found"!

@vinjana
Copy link
Contributor

vinjana commented Oct 9, 2017

  • When is the result empty?
  • Is there a cache for the job status table?
  • Do we need caching with LSF?
  • Is the cache ever emptied? How (expiration time? round-robin?)

@vinjana
Copy link
Contributor

vinjana commented Feb 12, 2018

Covered by solution #93, to throw an excpetion upon command error.

@vinjana vinjana closed this as completed Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants