Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Stale LEDs when reducing LED count #98

Closed
MathiasSeifert opened this issue Jan 17, 2023 · 1 comment · Fixed by #141
Closed

Bug: Stale LEDs when reducing LED count #98

MathiasSeifert opened this issue Jan 17, 2023 · 1 comment · Fixed by #141
Assignees
Labels
bug Something isn't working mcu Issues related to the main controll unit

Comments

@MathiasSeifert
Copy link
Collaborator

Describe the bug
When reducing the LED count in the UI below the number of LEDs on the strip, then the "extra" LEDs remain at their last status instead of being turned off.

To Reproduce
Steps to reproduce the behavior:

  1. Turn on the light on any zone, make sure all LEDs are lit up
  2. Go to 'Advanced' in the zone configuration and reduce the 'LED Count' to a number that is smaller the the actual count of LEDs in that zone.
  3. Click 'Apply Settings'
  4. Observe that the LEDs above the LED count are still lighting.

Expected behavior
When changing the LED Count any LED on the strip that is above the count should be turned off.

Additional context
The 'Average Power' that is printed on the console is also affected by this, as it only calculates the power based on the configured LEDs, not the actually lit up LEDs

@MathiasSeifert MathiasSeifert changed the title Stale LEDs when reducing LED count Bug: Stale LEDs when reducing LED count Jan 17, 2023
@JakobLichterfeld JakobLichterfeld added the bug Something isn't working label Jan 19, 2023
@TheRealKasumi TheRealKasumi added the mcu Issues related to the main controll unit label Jan 20, 2023
@TheRealKasumi TheRealKasumi self-assigned this Feb 4, 2023
@TheRealKasumi
Copy link
Owner

This is fixed for the maximum supported number of LED with the new LED driver. See #141. Problem in theory is still valid for unsupported high numbers of LEDs per zone (>250). But we cant output "off" to an infinite number of LEDs. I guess thats fair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mcu Issues related to the main controll unit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants