Renaming according to vote in Discord #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobLichterfeld
added
the
documentation
11 tasks
|
Frontend still to be done. So we shouldn’t merge before this😋. |
|
@TheRealKasumi and @danielbayerlein: lgtm, as I started the PR please review as well. |
|
Looks good to me so far. I think only the logo is left. So we are almost there. To not block the publishing we might continue with a placeholder. One of the pictures from the discord. |
|
Let’s go with this one for now. |
JakobLichterfeld
commented
Jun 9, 2023
|
I also adjusted the case and removed the logo for now. We can bring it back at some point if we want but it's not really relevant. With that I would go ahead and merge it. I tested everything manually and besides the logo loading issue (see discord) everything works fine. We can fix this as a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #174
closes #176
Renaming according to vote in Discord, (see #176)