fix: http methods #154
Merged
fix: http methods #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobLichterfeld
requested changes
Mar 5, 2023
|
@TheRealKasumi I've changed the HTTP request methods in the UI. |
danielbayerlein
added
enhancement
danielbayerlein
previously approved these changes
Mar 19, 2023
|
Works for me when you are sure the methods are correct😋. I can't really test it right now. But in case of problems we can do a quick fix I guess. |
|
Seems to be all working. Maybe a small adjustment is required after #172. |
TheRealKasumi
commented
Mar 28, 2023
danielbayerlein
approved these changes
Mar 31, 2023
TheRealKasumi
added a commit
that referenced
this pull request
Mar 31, 2023
* Sync with internal rep * update doc * Fix typo * Update methods * Remove secret information *laugh* * chore(ui): update http request methods Closes: #154 --------- Co-authored-by: Daniel Bayerlein
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #147
As discussed it would probably be "more correct" to use
patchinstead ofpostat some points. So let's do it, should be easy.Note: Frontend must be done before merging.