Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust endpoints that update configurations to use method patch instead of post #147

Closed
2 tasks done
TheRealKasumi opened this issue Feb 19, 2023 · 0 comments · Fixed by #154
Closed
2 tasks done

Adjust endpoints that update configurations to use method patch instead of post #147

TheRealKasumi opened this issue Feb 19, 2023 · 0 comments · Fixed by #154
Assignees
@danielbayerlein @TheRealKasumi
Labels
enhancement New feature or request frontend Issues related to the web-app mcu Issues related to the main controll unit
Milestone
1.1.0 Release

Comments

@TheRealKasumi
Copy link
Owner

TheRealKasumi commented Feb 19, 2023 •
edited by danielbayerlein
Loading

The configuration endpoints performing update operations currently use the http method post. We think that patch fits a little better here.

  • Update these endpoints
  • Update in the frontend
@TheRealKasumi TheRealKasumi added enhancement New feature or request frontend Issues related to the web-app mcu Issues related to the main controll unit labels Feb 19, 2023
@TheRealKasumi TheRealKasumi added this to the 1.1.0 Release milestone Feb 19, 2023
@TheRealKasumi TheRealKasumi mentioned this issue Mar 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbayerlein danielbayerlein

@TheRealKasumi TheRealKasumi

Labels
enhancement New feature or request frontend Issues related to the web-app mcu Issues related to the main controll unit
Projects
None yet
Milestone
1.1.0 Release
Development

Successfully merging a pull request may close this issue.

fix: http methods TheRealKasumi/NikoLight
2 participants
@danielbayerlein @TheRealKasumi