Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps: UI: use cache from lint during build #137

Closed
JakobLichterfeld opened this issue Jan 30, 2023 · 5 comments
Closed

DevOps: UI: use cache from lint during build #137

JakobLichterfeld opened this issue Jan 30, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@JakobLichterfeld
Copy link
Collaborator

During the UI build, the cache from the linting could be reused.

@JakobLichterfeld JakobLichterfeld added the enhancement New feature or request label Jan 30, 2023
@JakobLichterfeld JakobLichterfeld self-assigned this Jan 30, 2023
@danielbayerlein
Copy link
Collaborator

@JakobLichterfeld I think the cache is already in use, or did I miss something?

https://github.com/TheRealKasumi/TesLight/actions/runs/4055643631/jobs/6979063142#step:7:17

@JakobLichterfeld
Copy link
Collaborator Author

JakobLichterfeld commented Feb 3, 2023

@danielbayerlein One cache is in use for the linting step and another cache is in use for the build step from what I see. The goal would be to only use one cache for both jobs.

@danielbayerlein
Copy link
Collaborator

@JakobLichterfeld IMO the cache is reused because the jobs use the same cache key.

@JakobLichterfeld
Copy link
Collaborator Author

Imo they do not share the cache, as currently the step_id is used in cache key, which is different for the two jobs. I will debug and adjust if necessary.

JakobLichterfeld added a commit that referenced this issue Feb 4, 2023
@JakobLichterfeld
Copy link
Collaborator Author

Cache from Linting is already in use (step_id is not used in cache key but in path key)
Debug see here: https://github.com/TheRealKasumi/TesLight/actions/runs/4091926239/jobs/7056321033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants