Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge duplicated effects #123

Closed
2 tasks
TheRealKasumi opened this issue Jan 22, 2023 · 1 comment
Closed
2 tasks

Merge duplicated effects #123

TheRealKasumi opened this issue Jan 22, 2023 · 1 comment
Assignees
@danielbayerlein @TheRealKasumi
Labels
documentation Improvements or additions to documentation enhancement New feature or request frontend Issues related to the web-app mcu Issues related to the main controll unit
Milestone
1.1.0 Release

Comments

@TheRealKasumi
Copy link
Owner

TheRealKasumi commented Jan 22, 2023 •
edited
Loading

We currently have duplicated effects like the RainbowAnimator and RainbowAnimatorMotion that use basically identical code.

  • Try to merge them
  • Use the custom field Sensor Value to determine the type (random, motion, audio...)

Dicuss with @danielbayerlein
@TheRealKasumi TheRealKasumi added documentation Improvements or additions to documentation enhancement New feature or request frontend Issues related to the web-app mcu Issues related to the main controll unit labels Jan 22, 2023
@TheRealKasumi TheRealKasumi added this to the 1.1.0 Release milestone Jan 22, 2023
@TheRealKasumi TheRealKasumi mentioned this issue Jan 22, 2023
Closed
@TheRealKasumi
Copy link
Owner Author

I will close this issue since it was already done during my work on an upcoming firmware release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbayerlein danielbayerlein

@TheRealKasumi TheRealKasumi

Labels
documentation Improvements or additions to documentation enhancement New feature or request frontend Issues related to the web-app mcu Issues related to the main controll unit
Projects
None yet
Milestone
1.1.0 Release
Development

No branches or pull requests
2 participants
@danielbayerlein @TheRealKasumi