Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add fan mode #117

Merged
merged 2 commits into from
Jan 21, 2023
Merged

feat(ui): add fan mode #117

merged 2 commits into from
Jan 21, 2023

Conversation

danielbayerlein
Copy link
Collaborator

Closes: #114

@danielbayerlein danielbayerlein added the frontend Issues related to the web-app label Jan 21, 2023
@danielbayerlein danielbayerlein self-assigned this Jan 21, 2023
@danielbayerlein danielbayerlein mentioned this pull request Jan 21, 2023
Merged
TheRealKasumi
TheRealKasumi approved these changes Jan 21, 2023
View reviewed changes
Copy link
Owner

@TheRealKasumi TheRealKasumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just one general question. Is is always that case that the enums as number always have the correct value? Because otherwise this could go wrong.

Besides that....

100%
grafik

75%
grafik

50%
grafik

25%
grafik

Off
grafik

So all working perfectly fine and its applied correctly.

@danielbayerlein
Copy link
Collaborator Author

Just one general question. Is is always that case that the enums as number always have the correct value?

The enums always have the correct value. Start at 0 and all of the following members are auto-incremented from that point on.

https://www.typescriptlang.org/docs/handbook/enums.html#numeric-enums

@danielbayerlein danielbayerlein merged commit fd881bc into main Jan 21, 2023
@danielbayerlein danielbayerlein deleted the feat/issue-114_fan-mode branch January 21, 2023 13:55
TheRealKasumi pushed a commit that referenced this pull request Mar 31, 2023
@danielbayerlein @TheRealKasumi
feat(ui): add fan mode (#117)
f5cb4fe 
Closes: #114

Co-authored-by: TheRealKasumi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealKasumi TheRealKasumi TheRealKasumi approved these changes

Assignees

@danielbayerlein danielbayerlein

Labels
frontend Issues related to the web-app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select fan mode in ui
2 participants
@danielbayerlein @TheRealKasumi