Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): show only available hardware based options #119

Merged
merged 2 commits into from
Jan 22, 2023
Merged

feat(ui): show only available hardware based options #119

merged 2 commits into from
Jan 22, 2023

Conversation

danielbayerlein
Copy link
Collaborator

Closes: #109

@danielbayerlein danielbayerlein added the frontend Issues related to the web-app label Jan 21, 2023
@danielbayerlein danielbayerlein self-assigned this Jan 21, 2023
TheRealKasumi
TheRealKasumi approved these changes Jan 22, 2023
View reviewed changes
Copy link
Owner

@TheRealKasumi TheRealKasumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you tested all combinations using the mock. It's a little time consuming to test this in practice with the actual hardware. So I trust you there😋.

@danielbayerlein danielbayerlein merged commit ee2ae34 into main Jan 22, 2023
@danielbayerlein danielbayerlein deleted the feat/issue-109_hardware-info branch January 22, 2023 09:34
TheRealKasumi pushed a commit that referenced this pull request Mar 31, 2023
@danielbayerlein @TheRealKasumi
feat(ui): show only available hardware based options (#119)
53720f9 
Closes: #109

Co-authored-by: TheRealKasumi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealKasumi TheRealKasumi TheRealKasumi approved these changes

Assignees

@danielbayerlein danielbayerlein

Labels
frontend Issues related to the web-app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only show available hardware-based options in the ui
2 participants
@danielbayerlein @TheRealKasumi