Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Bounce option for Sparkle effect #106

Closed
MathiasSeifert opened this issue Jan 18, 2023 · 1 comment · Fixed by #120
Closed

Feature request: Bounce option for Sparkle effect #106

MathiasSeifert opened this issue Jan 18, 2023 · 1 comment · Fixed by #120
Assignees
Labels
enhancement New feature or request frontend Issues related to the web-app mcu Issues related to the main controll unit

Comments

@MathiasSeifert
Copy link
Collaborator

The 'Sparkle'-effect should have an option (e.g. 'Bounce') that cases the sparkles to bounce back at the end of the LED strip and reverse direction instead of disappearing.
The spawning of new sparkles needs to take this into account as sparks could live forever with this option enabled and sparkle fade/sparkle friction set to 0.

@JakobLichterfeld JakobLichterfeld added the enhancement New feature or request label Jan 19, 2023
@TheRealKasumi TheRealKasumi added frontend Issues related to the web-app mcu Issues related to the main controll unit labels Jan 21, 2023
@TheRealKasumi TheRealKasumi self-assigned this Jan 22, 2023
@TheRealKasumi
Copy link
Owner

I will add a simple flag that will bounce the particles at the end of the strip when its set. Since the number of particles is static and can be adjusted by the user, I dont see an issue with infinite lifetime. In fact this could be intended by the user. So maybe you want 3 particles bouncing all the time. Imo this should be the decision of the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Issues related to the web-app mcu Issues related to the main controll unit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants