Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelled trade orders appear in "My Completed Trades" #81

Open
sudoebm opened this issue May 25, 2021 · 6 comments
Open

Cancelled trade orders appear in "My Completed Trades" #81

sudoebm opened this issue May 25, 2021 · 6 comments
Assignees
Labels
bug Something isn't working go live requirement Needed for go live

Comments

@sudoebm
Copy link

sudoebm commented May 25, 2021

Cancelling an active trade before the trade occurs still moves the now cancelled trade to the "My Completed Trades" window.
Screenshot_2

@tylerjohneddy
Copy link
Contributor

could you specify what the desired behavior would be, thanks

@tylerjohneddy tylerjohneddy self-assigned this May 25, 2021
@sudoebm
Copy link
Author

sudoebm commented May 25, 2021

could you specify what the desired behavior would be, thanks

The desired behavior would be to null the trade and remove it.

@BKdilse
Copy link
Collaborator

BKdilse commented May 25, 2021

Fully cancelled should not appear anywhere, partial complete should appear as the partial amounts.

@sudoebm
Copy link
Author

sudoebm commented May 25, 2021

Fully cancelled should not appear anywhere, partial complete should appear as the partial amounts.

The example shown above was created by clicking the "Cancel" button on the "My Active Trades" window.

@BKdilse BKdilse added bug Something isn't working go live requirement Needed for go live labels Jun 8, 2021
@bennytehcat
Copy link
Collaborator

Quick note, Binance does not "delete" the record from your account. So if you create 100 trades, then cancel all 100, they will appear in your order history as, "Canceled". What about this?

@tylerjohneddy
Copy link
Contributor

maybe a mixture of what @BKdilse said and this @bennytehcat, show the fulfilled amount and show the cancled amount ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go live requirement Needed for go live
Projects
None yet
Development

No branches or pull requests

4 participants