Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace busy waiting for command to complete with a callback. #47

Open
That-One-Nerd opened this issue Apr 10, 2023 · 1 comment
Open

Replace busy waiting for command to complete with a callback. #47

That-One-Nerd opened this issue Apr 10, 2023 · 1 comment
Labels
improvement

Comments

@That-One-Nerd
Copy link
Owner

Currently, the shell executes commands on a separate background thread and busy waits until completion. This wastes CPU cycles and can be improved by adding a callback to the background worker's completion.
@That-One-Nerd That-One-Nerd converted this from a draft issue Apr 10, 2023
@That-One-Nerd That-One-Nerd moved this from Soon to In Progress in Make a Decent Command Line Apr 18, 2023
@That-One-Nerd That-One-Nerd moved this from In Progress to Delayed in Make a Decent Command Line Apr 18, 2023
@That-One-Nerd
Copy link
Owner Author

This is currently delayed because for one, the current system actually uses far less processing than I expected and using a callback would require a bunch of asynchronous joining which I don't like on a good day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
Make a Decent Command Line
Status: Delayed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@That-One-Nerd