Added branding changes #1072
Merged
Added branding changes #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnehapk
force-pushed
the
update-login-view
branch
from
b751ca3 to
b12e48a
Compare
|
Screenshots for login page and about modal -
|
cloudbehl
reviewed
Sep 25, 2018
| @@ -5,5 +5,6 @@ | |||
| "msgRefreshIntervalTime": 5, | |||
| "statusRefreshIntervalTime": 30, | |||
| "eventsRefreshIntervalTime": 20, | |||
| "volumeRefreshInterval": 10 | |||
| "volumeRefreshInterval": 10, | |||
| "releaseVersion": "1.6.3" | |||
There was a problem hiding this comment.
@Neha can we anyhow import the package.json file to use the release version. I think it will be a headache for us while building the UI package to change it every time. Just a thought!
There was a problem hiding this comment.
@cloudbehl Agreed. But since the package.json file doesn't get copied to the dist folder and its not a good idea to keep the package manager configuration file in the production environment, I need to make it configurable here. In future, this version number should be available from the API.
There was a problem hiding this comment.
Good idea to make it configurable for now.
Bugzilla: 1627988 tendrl-github-id: Tendrl#1067
gnehapk
force-pushed
the
update-login-view
branch
from
b12e48a to
23594cd
Compare
|
@gnehapk please update screenshots on PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugzilla: 1627988
tendrl-github-id: #1067