[Functional test] [WIP] Cluster feature #1063

Josh-Everett · 2018-08-22T18:09:56Z

Initial scenarios for cluster.feature for BDD tests

Tendrl-bug-id: #1058

Signed-off-by: Josh Everett [email protected]

Tendrl-bug-id: #1058 Signed-off-by: Josh Everett <[email protected]>

centos-ci · 2018-08-22T18:09:58Z

Can one of the admins verify this patch?

centos-ci · 2018-08-22T18:09:58Z

Can one of the admins verify this patch?

cloudbehl · 2018-08-23T14:43:23Z

test/behavior/tendrl/cluster.feature

+Feature: CLUSTER
+
+  Scenario: Import a cluster


Scenario: Import Cluster page should be available

cloudbehl · 2018-08-23T14:45:09Z

test/behavior/tendrl/cluster.feature

+     Then User sees the "import-clusters" page
+
+  Scenario: Unmanage a cluster


This scenario should come once the import is done so move it after Scenario: Naming an imported cluster

cloudbehl · 2018-08-23T14:46:39Z

test/behavior/tendrl/cluster.feature

+  Scenario: Unmanage a cluster
+    Given User is on "clusters" page
+     When User clicks on cluster dropdown


it's a kebab menu.
User clicks on kebab menu

cloudbehl · 2018-08-23T14:49:53Z

test/behavior/tendrl/cluster.feature

+
+  Scenario: Unmanage a cluster
+    Given User is on "clusters" page


Given User is on cluster page and has at least one cluster available

cloudbehl · 2018-08-23T14:53:34Z

test/behavior/tendrl/cluster.feature

+Feature: CLUSTER
+


the first scenario should be the user is on cluster list page and user is able to see one cluster at least.

cloudbehl · 2018-08-23T14:56:18Z

test/behavior/tendrl/cluster.feature

+      And User sees cluster is unmanaged
+
+  Scenario: Naming an imported cluster


This has multiple scenarios.

Normal import
import with name
import with enable profiling
import with disable profiling
import with unchanged profiling
normal import with enable profiling
Normal import with disable profiling
Normal import with unchanged profiling

I suggest we create a new file for import

nathan-weinberg · 2018-08-23T14:54:13Z

test/behavior/tendrl/cluster.feature

+      And User clicks on unmanage button
+      And User sees "Unmanage Cluster" dialogue box
+      And User clicks on "unmanage" button


Need consistency with being generic or not generic

nathan-weinberg · 2018-08-23T14:56:03Z

test/behavior/tendrl/cluster.feature

+  	  And User clicks on "close" button
+  	 Then User sees the "cluster" page
+  	  And User sees name in cluster list view


Maybe make cluster name generic so you can assert that what was entered is equal to what appears at the end

nathan-weinberg · 2018-08-23T14:57:29Z

test/behavior/tendrl/cluster.feature

+  Scenario: Cluster status Icon in list view
+    Given User is on "clusters" page
+    When  I see "cluster" list view available


Use "User" instead of "I"

nathan-weinberg · 2018-08-23T14:58:17Z

test/behavior/tendrl/cluster.feature

+    And   I should see the hyperlink on Cluster Name
+    And   I click on Cluster name
+    Then  I should see the object detail view


This is exactly the same as the scenario above apart from the title

nathan-weinberg · 2018-08-23T14:59:01Z

test/behavior/tendrl/cluster.feature

+  Scenario: Sort the Clusters by Name
+    Given User is on "clusters" page
+     When User should select "name" from the dropdownzz


"dropdownzz"

nathan-weinberg

Other than that LGTM

nathan-weinberg · 2018-08-23T18:05:54Z

test/behavior/tendrl/cluster.feature

+      And User sees "Unmanage Cluster" dialog box
+      And User clicks on "unmanage" button
+     Then User sees "Cluster Task" dialog box
+      And User closes "Cluster Tast" dialog box


cloudbehl · 2018-08-24T07:22:49Z

test/behavior/tendrl/cluster.feature

+Feature: CLUSTER
+
+  Scenario: User views available cluster 


Scenario doesn't start with the user.

Scenario: Cluster is available

cloudbehl · 2018-08-24T07:27:58Z

test/behavior/tendrl/cluster.feature

+     Then User sees the "import-clusters" page
+
+  Scenario: Unmanage a cluster


will move this also in import and unmanage feature file

cloudbehl · 2018-08-24T07:32:10Z

@Josh-Everett Can you divide this also in two files one will be the un-imported cluster and managed cluster. Otherwise, the scenarios will clash.

cloudbehl · 2018-10-01T09:48:00Z

@Josh-Everett you have rebased your PR with master. I can see the neha's commit on your PR. Please fix

cloudbehl · 2018-10-01T09:52:32Z

test/behavior/tendrl/cluster_unmanaged.feature

@@ -0,0 +1,129 @@
+Feature: CLUSTER_UNMANAGED
+
+  Scenario: User sees cluster lists page after logging in


you don't need to do this step as it's handled on login page.

cloudbehl · 2018-10-03T17:54:00Z

test/behavior/tendrl/cluster_unmanaged.feature

+  Scenario: User sees cluster is unmanaged
+    Given User is on the "cluster list" page
+      And has at least one cluster available
+     Then User should see "No" under Managed


Then User should see "No" under Managed property of cluster

I think this will make more sense

cloudbehl · 2018-10-03T17:57:33Z

test/behavior/tendrl/cluster_unmanaged.feature

+    Given User is on the "cluster list" page
+      And has at least one cluster available
+     When User hovers over cluster status icon
+      And User should see status is unknown


And User should see status is "unknown"

@Josh-Everett make it generic as status can be unknown, down and up

cloudbehl · 2018-10-03T17:59:16Z

test/behavior/tendrl/cluster_unmanaged.feature

+     When User passes correct login information
+     Then User should see "cluster list" page
+
+  Scenario: User sees cluster is unmanaged


don't start scenarios from User.

Scenario: Cluster is non-imported

cloudbehl · 2018-10-03T18:02:13Z

test/behavior/tendrl/cluster_unmanaged.feature

+      And has at least one cluster available
+     Then User should see "No" under Managed
+
+  Scenario: User sees cluster status icon


don't start with user

cloudbehl · 2018-10-03T18:03:31Z

test/behavior/tendrl/cluster_unmanaged.feature

+     Then User should see "No" under Managed
+
+  Scenario: User sees cluster status icon
+    Given User is on the "cluster list" page


same as above scenario's given statement.

cloudbehl · 2018-10-03T18:10:32Z

test/behavior/tendrl/cluster_unmanaged.feature

+      And has at least one cluster available
+     Then User should see Cluster Version info
+
+  Scenario: User sees hosts information


We need to add one more scenario of checking a host count is correct.

cloudbehl · 2018-10-03T18:10:57Z

test/behavior/tendrl/cluster_unmanaged.feature

+     When User clicks on hosts link
+     Then User should be brought to hosts page
+
+  Scenario: Cluster is unavailable for import


which scenario is this? can you explain

I'm not sure in what other circumstances this situation arises, but if you unmanage the cluster you are unable to import it again until the task is complete. During this time the import button is greyed out and unusable. Not sure if this is a relevant scenario for us to test.

cloudbehl · 2018-10-03T18:11:56Z

test/behavior/tendrl/cluster_unmanaged.feature

+    Given User is on the "cluster list" page
+      And has at least one cluster available
+     When the cluster is available for import
+     Then the import button should be usable


Then the import button should be available in kebab menu

Should we still classify the import button as being associated with the kebab menu even though it is a standalone button?

cloudbehl · 2018-10-03T18:13:03Z

test/behavior/tendrl/cluster_unmanaged.feature

+  Scenario: Cluster is available to import
+    Given User is on the "cluster list" page
+      And has at least one cluster available
+     When the cluster is available for import


When the cluster is "Ready to import"

cloudbehl · 2018-10-03T18:14:20Z

test/behavior/tendrl/cluster_unmanaged.feature

+     When User filters by an "invalid" cluster name
+     Then User should see no clusters
+
+  Scenario: User logs out


no need to handle this

Adding scenarios to cluster.feature

a6ea712

Tendrl-bug-id: #1058 Signed-off-by: Josh Everett <[email protected]>

Josh-Everett requested review from a team as code owners August 22, 2018 18:09

cloudbehl requested changes Aug 23, 2018

View reviewed changes

nathan-weinberg suggested changes Aug 23, 2018

View reviewed changes

Changes to cluster.feature to reflect requested changes

d0b2790

nathan-weinberg suggested changes Aug 23, 2018

View reviewed changes

correcting typo

052409b

cloudbehl requested changes Aug 24, 2018

View reviewed changes

reset head, added unmanaged.feature

8eb8bfc

cloudbehl reviewed Oct 3, 2018

View reviewed changes

cloudbehl requested changes Oct 3, 2018

View reviewed changes

adjusting gherkin

c0f5e18

Josh-Everett closed this Jan 1, 2023

Josh-Everett deleted the cluster-feature branch January 1, 2023 23:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Functional test] [WIP] Cluster feature #1063

[Functional test] [WIP] Cluster feature #1063

Josh-Everett commented Aug 22, 2018

centos-ci commented Aug 22, 2018

centos-ci commented Aug 22, 2018

cloudbehl Aug 23, 2018

cloudbehl Aug 23, 2018

cloudbehl Aug 23, 2018

cloudbehl Aug 23, 2018

cloudbehl Aug 23, 2018

cloudbehl Aug 23, 2018

nathan-weinberg Aug 23, 2018

nathan-weinberg Aug 23, 2018

nathan-weinberg Aug 23, 2018

nathan-weinberg Aug 23, 2018

nathan-weinberg Aug 23, 2018

nathan-weinberg Aug 23, 2018

nathan-weinberg left a comment

nathan-weinberg Aug 23, 2018

cloudbehl Aug 24, 2018

cloudbehl Aug 24, 2018

cloudbehl commented Aug 24, 2018

cloudbehl commented Oct 1, 2018

cloudbehl Oct 1, 2018

cloudbehl Oct 3, 2018

cloudbehl Oct 3, 2018

cloudbehl Oct 3, 2018

cloudbehl Oct 3, 2018

cloudbehl Oct 3, 2018

cloudbehl Oct 3, 2018

cloudbehl Oct 3, 2018

Josh-Everett Oct 5, 2018

cloudbehl Oct 3, 2018

Josh-Everett Oct 5, 2018

cloudbehl Oct 3, 2018

cloudbehl Oct 3, 2018

		Then User sees the "import-clusters" page

		Scenario: Unmanage a cluster


		Scenario: Unmanage a cluster
		Given User is on "clusters" page

		And User sees cluster is unmanaged

		Scenario: Naming an imported cluster

		@@ -0,0 +1,129 @@
		Feature: CLUSTER_UNMANAGED

		Scenario: User sees cluster lists page after logging in

[Functional test] [WIP] Cluster feature #1063

[Functional test] [WIP] Cluster feature #1063

Conversation

Josh-Everett commented Aug 22, 2018

centos-ci commented Aug 22, 2018

centos-ci commented Aug 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nathan-weinberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cloudbehl commented Aug 24, 2018

cloudbehl commented Oct 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment