Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API call to trigger ExpandClusterWithDetectedPeers flow #385

Closed
shirshendu opened this issue Mar 8, 2018 · 3 comments
Closed

API call to trigger ExpandClusterWithDetectedPeers flow #385

shirshendu opened this issue Mar 8, 2018 · 3 comments
Assignees

Comments

@shirshendu
Copy link

As per Tendrl/commons#805 (comment) , we need an API call that can enqueue a job that triggers the ExpandClusterWithDetectedPeers flow.
https://github.com/Tendrl/commons/pull/831/files#diff-1a5320aa0fd1eea178e6ed255509c9c4 holds definitions required for the spec.

@shirshendu shirshendu self-assigned this Mar 8, 2018
shirshendu pushed a commit to shirshendu/api that referenced this issue Mar 9, 2018
@shirshendu
Copy link
Author

There is also another existing (undocumented?) API '/:cluster_id/ExpandCluster`, which I'm assuming is in the old format.
That uses a flow called 'ExpandCluster', and needs node details (which are already available on the page with the expand cluster button).
I would like to remove it; is this API still in use? What are the scenarios? @Tendrl/frontend @Tendrl/ux

@shirshendu
Copy link
Author

Tendrl/ui/issues/848 depends on this

shirshendu pushed a commit to shirshendu/api that referenced this issue Mar 14, 2018
@r0h4n
Copy link
Contributor

r0h4n commented Mar 14, 2018

@shirshendu The flow "ExpandCluster" was coded as a day 0 flow. Where it would actually install gluster on the new nodes using gdeploy and adds them to the Gluster trusted storage pool

The current "ExpandClusterWithDetectedPeers" simply detects new nodes which are recently added to the Gluster trusted storage pool by the user, it does not install gluster on the new nodes and assumes it is done by the user.

The old "ExpandCluster" flow is already disabled via definitions, the API can use that to decide if it is a valid flow or not
Check: https://github.com/Tendrl/commons/blob/master/tendrl/commons/objects/definition/master.yaml#L38

shirshendu pushed a commit to shirshendu/api that referenced this issue Mar 15, 2018
@shirshendu shirshendu added this to the Milestone 4 (2018) milestone Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants