Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix: local variable #60

Closed
wants to merge 1 commit into from
Closed

front: fix: local variable #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions front/src/utils/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ export enum Layout {
Default = "Default"
}

export const FULL_BASE_API_URL = import.meta.env.PROD
? `${window.location.origin}/api`
: "http://localhost:8000/api"
const IS_LOCAL_DEV = import.meta.env.TELESCOOP_DEV === 1

export const FULL_BASE_API_URL = IS_LOCAL_DEV
? "http://localhost:8000/api"
: import.meta.env.VITE_BASE_API_URL || `${window.location.origin}/api`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cette variable d'environnement BASE_API_URL (le préfixe VITE est ajouté par Vite) est définie en production (via deploy/roles/frontend/templates/frontend.env). Elle est donc systématiquement présente.

Par cohérence, je suis pour n'avoir que l'option import.meta.env.VITE_BASE_URL ou bien la supprimer de frontend.env.

(et d'ajouter un commentaire dessus).

Mais du coup, si le code devient :

export const FULL_BASE_API_URL = IS_LOCAL_DEV
  ? "http://localhost:8000/api"
  : import.meta.env.VITE_BASE_API_URL

Alors il serait tout aussi correct d’écrire = ma proposition finale

export const FULL_BASE_API_URL =  import.meta.env.VITE_BASE_API_URL || "http://localhost:8000/api"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il serait aussi + correct d’écrire : import.meta.env.BASE_URL que window.location.origin selon moi.


export const MIN_ZOOM = 12
export const MAX_ZOOM = 20