Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

UpdateTransform remove used_quaternion flag #237

Closed
sainsay opened this issue Apr 4, 2019 · 2 comments
Closed

UpdateTransform remove used_quaternion flag #237

sainsay opened this issue Apr 4, 2019 · 2 comments
Labels
refactor Request to re-factor a working system/class/etc.

Comments

@sainsay
Copy link
Contributor

sainsay commented Apr 4, 2019

Is your request related to a problem? Please describe.
Current solution is hacky and error prone.
node.cpp

Describe the solution you'd like
remove the need for a boolean by converting EulerRotation to Quaternion values when setting rotation in node.cpp instead of doing the conversion during UpdateTransform()
@sainsay sainsay added the refactor Request to re-factor a working system/class/etc. label Apr 4, 2019
@Nielsbishere
Copy link
Contributor

Related to #121

@VZout
Copy link
Contributor

VZout commented May 6, 2019

Closing since its mostly duplicate from #121.

@VZout VZout closed this as completed May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
refactor Request to re-factor a working system/class/etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@VZout @sainsay @Nielsbishere