Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Model loader intermediate data #163

Open
Nielsbishere opened this issue Feb 18, 2019 · 1 comment
Open

Model loader intermediate data #163

Nielsbishere opened this issue Feb 18, 2019 · 1 comment
Labels
design change Request to re-design a system/class/etc.

Comments

@Nielsbishere
Copy link
Contributor

Is your design request related to a problem? Please describe.
The intermediate data of model loader copies data twice and the copying doesn't use memcpy but uses operator=. It also uses vectors of attributes and not vectors of structs, meaning that you can't memcpy them over but have to swap them around again. This increases load time and also means the same data is duplicated while it doesn't have to.

Describe the solution you'd like
Use memcpy where needed, change assimp wrapper to allow direct copying.

Describe alternatives you've considered
N.A. This doesn't have to be fixed, but it will decrease load times.

Additional context
N.A.

@Nielsbishere Nielsbishere added the design change Request to re-design a system/class/etc. label Feb 18, 2019
@Nielsbishere
Copy link
Contributor Author

#222

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design change Request to re-design a system/class/etc.
Projects
None yet
Development

No branches or pull requests

1 participant