Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show an error when entering the same value from the settings #326

Merged
merged 7 commits into from
Jul 31, 2024
Merged

Show an error when entering the same value from the settings #326

merged 7 commits into from
Jul 31, 2024

Conversation

mctaylors
Copy link
Member

Closes #324

@mctaylors mctaylors added the type: fix PRs that fix bugs, typos, style issues. label Jul 20, 2024
@pull-request-size pull-request-size bot added the size/S PRs that change 20-100 lines. label Jul 20, 2024
@mctaylors mctaylors force-pushed the settings-reapply-fix branch from e97f1c1 to cc3167b Compare July 20, 2024 19:28
@mctaylors mctaylors marked this pull request as ready for review July 20, 2024 19:35
@mctaylors mctaylors requested a review from a team as a code owner July 20, 2024 19:35
@mctaylors mctaylors requested a review from Octol1ttle July 21, 2024 08:22
@Octol1ttle Octol1ttle self-assigned this Jul 21, 2024
Octol1ttle
Octol1ttle approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Octol1ttle Octol1ttle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look correct, but I can't point out anything specific, and this whole system is gonna be rewritten some day anyway, so no harm in merging this.

@Octol1ttle Octol1ttle merged commit d6d2660 into master Jul 31, 2024
1 check passed
@Octol1ttle Octol1ttle deleted the settings-reapply-fix branch July 31, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Octol1ttle Octol1ttle Octol1ttle approved these changes

Assignees

@Octol1ttle Octol1ttle

Labels
size/S PRs that change 20-100 lines. type: fix PRs that fix bugs, typos, style issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The bot will send a successful "Setting value changed" message even if the value stays the same
2 participants
@mctaylors @Octol1ttle