Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing 'Play on Kodi' should pause local playback #11896

Open
6 tasks done
Nosen92 opened this issue Jan 11, 2025 · 2 comments
Open
6 tasks done

Pressing 'Play on Kodi' should pause local playback #11896

Nosen92 opened this issue Jan 11, 2025 · 2 comments
Labels
feature request Issue is related to a feature in the app niche Only relevant to a very small amount of people player Issues related to any player (main, popup and background)

Comments

@Nosen92
Copy link

Nosen92 commented Jan 11, 2025

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Background:

When watching a YouTube video in Newpipe, pressing 'Play on Kodi' switches to the Kore app which sends the command to play the YouTube video on the Kodi instance (a media player connected to the TV).

Expected:

It is safe to assume that if the user presses 'Play on Kodi', they want to switch from watching the video on their phone to watching it on their TV. Playback in Newpipe should therefore be paused, so there is not two devices playing the video at once.

Actual:

However, the Newpipe app currently doesn't pause playback if it was playing when 'Play on Kodi' is pressed, so the user ends up with having the video playing on both the phone and the TV simultaneously, which is almost never desired.

Proposed solution:

When 'Play on Kodi' is pressed, check if Newpipe is playing. If yes, pause before proceeding with the handoff to Kodi.

Why do you want this feature?

The main problem arisibg from the current Newpipe behaviour is having the video playing from two devices simultaneously, which isn't desirable.

Additional information

IMG_20240922_125448

@Nosen92 Nosen92 added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 11, 2025
@ShareASmile ShareASmile added player Issues related to any player (main, popup and background) niche Only relevant to a very small amount of people and removed needs triage Issue is not yet ready for PR authors to take up labels Jan 18, 2025
@lameventanas
Copy link

This is a great idea! Optionally, it could also marked the video as watched.

@Nosen92
Copy link
Author

Nosen92 commented Jan 25, 2025

This is a great idea! Optionally, it could also marked the video as watched.

That is a good idea. But it warrants its own issue, because there are some further considerations that need to be made, like: should the 'Play on Kodi' button always mark a video as watched, even if the handoff to Kodi fails? If not, how do we check if the handoff was successful? Should we check if the user actually finishes watching on Kodi before marking as watched? Etc. These considerations need not be made in this issue here, because worst case scenario is that the video is paused locally and doesn't start on the TV for whatever reason, and that 'false positive' pause is not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app niche Only relevant to a very small amount of people player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

3 participants