Welcome to SharpCaster Discussions! #158
Replies: 4 comments 7 replies
-
Hi, As I see you are retfactoign the library to use more up to date NET versions, I do also revisit my code now. Since your fix for #161 (thx. again, for that), I am able to add my ‘queue’-customizations with your easily accessible service-oriented approach now (see https://github.com/RobertK66/HomeAudio/tree/main/QueueCaster for details). Nevertheless, there are some minor quirks with this. I have no Idea (yet) how the second issue could be solved more elegant. But as I saw your discussion folder here, I decided to use this as little feedback hub. Maybe There is some easy way to get around with existing code or you could think of introducing some other way of ‘class overwrite’ or ‘protocol detection’ in the existing IOC Container. Thx. and looking forward to use and improve on new versions ;-), |
Beta Was this translation helpful? Give feedback.
-
Ok, having queues in the base impl would solve my issue at all ;-). But I don’t know if this can be done without changing to much for other use cases. For this or other/further customizations I would suggest something like I wrote here (in ListAllMessageClasses() ): https://github.com/RobertK66/HomeAudio/blob/main/QueueCaster/ChromecastClient.cs If you provide a constructor where an optional (list of) assembly(s) with message classes could be passed in, then advanced users can write their own versions of every Message class. Constructor can make sure that only one class per Name exists (and the customization ‘overwrites’ the base impl)! Or one could deliver a separate ‘standalone’ dll with a special model version, or the ‘base-dll’ comes as separate one only used if no other is provided ….. |
Beta Was this translation helpful? Give feedback.
-
Hi, I am not sure if you have time and are in the mood to accept changes as pull request on this ancient repos. If so, I would invest some more time to give overview of 'known device differences' in the Unit Tests. ( Also I do not succeed yet to run them all at once because there are some issues with the device left in different states and the sequence of tests does matter here 😢 ) feel free to see https://github.com/RobertK66/SharpCaster/tree/queuecaster for my current state of code |
Beta Was this translation helpful? Give feedback.
-
Great and thx., Here #294 you are 😄 . |
Beta Was this translation helpful? Give feedback.
-
👋 Welcome!
We’re using Discussions as a place to connect with other members of our community. We hope that you:
build together 💪.
To get started, comment below with an introduction of yourself and tell us about what you do with this community.
Beta Was this translation helpful? Give feedback.
All reactions