Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM: eslint-plugin-query v4.38 tagged as latest #6655

Closed
JamesBream opened this issue Jan 6, 2024 · 2 comments · Fixed by #6658
Closed

NPM: eslint-plugin-query v4.38 tagged as latest #6655

JamesBream opened this issue Jan 6, 2024 · 2 comments · Fixed by #6658

Comments

@JamesBream
Copy link

JamesBream commented Jan 6, 2024

Describe the bug

The most recent build of @tanstack/eslint-plugin-query v4.38.0 has been tagged as latest on NPM despite being a patch release for the old v4 branch. This means that this version is being suggested as an upgrade from the 5.x versions in package managers (at least for me with yarn).

Guessing it's just the v4 publish pipeline that hasn't been updated since v5 shipped.

Your minimal, reproducible example

N/A

Steps to reproduce

  1. Install @tanstack/eslint-plugin-query@latest
  2. Check installed version is 4.38.0

Expected behavior

I expected 5.17.1 to be the version installed with the latest tag.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

  • OS: macOS 14.2.1 - Node: 18.18.2 - Yarn: 4.0.2

Tanstack Query adapter

None

TanStack Query version

5.17.1

TypeScript version

No response

Additional context

No response

@TkDodo
Copy link
Collaborator

TkDodo commented Jan 6, 2024

I think this needs to be fixed in the config package. @crutchcorn @lachlancollins FYI. Publishing an older major shouldn't tag as latest. I think right now every release tags as latest.

as a workaround for now, I'll trigger a new v5 patch release so that it becomes latest again.

@lachlancollins
Copy link
Member

lachlancollins commented Jan 6, 2024

Fixed here: TanStack/config#24

The bug already existed in the query repo before we replaced the config! I guess v4 doesn't get published to that often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants