Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test dimer.py does not test anything #15

Open
HugoStrand opened this issue Nov 27, 2024 · 1 comment
Open

Test dimer.py does not test anything #15

HugoStrand opened this issue Nov 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@HugoStrand
Copy link
Member

HugoStrand commented Nov 27, 2024

The test dimer.py does not check the result with any reference data, see
https://github.com/TRIQS/ctseg/blob/3.3.x/test/python/dimer.py#L113

(Part of openjournals/joss-reviews#7425)

@nkavokine
Copy link
Collaborator

Dear Hugo, thanks for pointing this out. This is on purpose since for this particular test case, the results of short runs can exhibit large variations across platforms (see comment in the file header). This test is rather meant as a correctness test, since the result can be compared to ED (dimer_pyed.ref.h5). But a meaningful comparison would require a longer run than would be practical for an automatic test, therefore no comparison to a reference is carried out in this test as a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants