Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Operation.is_service_operation #625

Closed
PaulFarault opened this issue Oct 22, 2024 · 1 comment
Closed

Remove Operation.is_service_operation #625

PaulFarault opened this issue Oct 22, 2024 · 1 comment
Labels
refactor

Comments

@PaulFarault
Copy link
Contributor

Type inference won't work if using the Operation.is_service_operation regex.

It's better to check if operation.component_name is null for now. Moreover, it will facilitate the refactor of the Operation class later.
@PaulFarault PaulFarault mentioned this issue Oct 22, 2024
Merged
2 tasks
@PaulFarault
Copy link
Contributor Author

This has been fixed by the refactor of the Operation class done by #635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulFarault