Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Replace several asset properties using conditions #523

Open
edwinvandenbelt opened this issue Jan 4, 2024 · 1 comment
Labels
breaking This issue leads to a major version WT1 To be discussed at the next meeting
Milestone

Comments

@edwinvandenbelt
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

in the SharedProperties object there are several fields, that should be replaced by conditions:

  • travelAbroad: conditionNoTravelAbroad
  • undergroundParking: conditionNoUndergroundParking
  • helmetRequired: conditionRequiredAncillaries (allows also to require snow chains)
  • pets: conditionNoPets
  • smoking: conditionNoSmoking

Urgency

Minor (this feature is nice to have, no rush to implement this), because it reduces the complexity of the sharedproperties object, and these features are not real features, but terms & conditions.

@edwinvandenbelt edwinvandenbelt added WT1 To be discussed at the next meeting breaking This issue leads to a major version labels Jan 4, 2024
@edwinvandenbelt edwinvandenbelt added this to the Elephant - 2.0 milestone Jan 31, 2024
@edwinvandenbelt
Copy link
Collaborator Author

moved them to tripExecutionConditions.

@edwinvandenbelt edwinvandenbelt moved this to In review V2.0 in WT1 Kanban Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This issue leads to a major version WT1 To be discussed at the next meeting
Projects
Status: In review V2.0
Status: In review V2.0
Development

No branches or pull requests

1 participant