[#12048] Refactor FeedbackResponses and FeedbackResponseComments attributes #12791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlimm
force-pushed
the
v9-refactor-entities
branch
5 times, most recently
from
4d2f424 to
b213aab
Compare
domlimm
force-pushed
the
v9-refactor-entities
branch
from
b213aab to
4861d41
Compare
domlimm
force-pushed
the
v9-refactor-entities
branch
3 times, most recently
from
ab40081 to
424b2ab
Compare
domlimm
force-pushed
the
v9-refactor-entities
branch
from
29c0c1e to
bc5c4f7
Compare
- Update test input data file - Fix bug in incorrect parameter - Add getUserByEmail functionality - Reorder loading of entities to account for FK constraints
…d test data (partial)
domlimm
force-pushed
the
v9-refactor-entities
branch
from
3c27af8 to
868897b
Compare
|
Folks, This PR seems to be stalling (no activities for the past 74 days). 🐌 😢 |
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
@domlimm Could you fix the failing CI |
|
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
|
@domlimm reopen it when you are ready to continue with it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048. Fixes #12724
Outline of Solution
FeedbackResponses:
giverattribute to useUserentity insteadrecipientattribute to useUserentity insteadFeedbackResponseComments:
giverattribute to useUserentity insteadrecipientattribute to useUserentity insteadlastEditorattribute to useUserentity instead