Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DungeonReset] Connection issues from NetworkCompatibility EveryoneMustHaveMod flag #12

Open
Steel-skull opened this issue Oct 11, 2021 · 3 comments
Labels
Docs Improvements or additions to documentation

Comments

@Steel-skull
Copy link

Steel-skull commented Oct 11, 2021

I've had a few reports by players that when they have just bepinex installed (no other mods) they get an incompatibility / cant connect error.

No issue with vanilla players joining.

(Bepinex only) never installed dungeon reset > error
installed the dungeon reset mod and 2 dependent mods > could connect
disabled these mods > could connect
then disabled mods one by one > could connect
then did clean startup from Steam > could connect

no logs are thrown from server
client logs im waiting for a player to send them to me

@T3kla
Copy link
Owner

T3kla commented Oct 11, 2021

This is by design. If the server have the mod, every client must have the mod and have it updated to the servers version.

I'm thinking about disabling this behaviour but then everyone that doesn't have the mod will not experience dungeon resets.

This is because I can't tell the server instance to reset dungeons, since their pieces are not active in the server scene but only in the clients who travel to dungeons and activate them. So in a sense, it is clients who have to reset dungeons for the server.

The thing is that people could expect dungeons resets because it is installed in the server, but then don't experience them and think it is broken. That is why it is initially enforced for everyone joining.

@T3kla T3kla changed the title connection issues [DungeonReset] Connection issues from NetworkCompatibility EveryoneMustHaveMod flag Oct 11, 2021
@T3kla T3kla added the Docs Improvements or additions to documentation label Oct 11, 2021
@Steel-skull
Copy link
Author

I suspected as much thanks for the prompt response.
instead of disabling it would it be possible to put it in the config as optional? depending on the server config file?

best of both worlds
also thanks for the hard work on the mods

@T3kla
Copy link
Owner

T3kla commented Oct 11, 2021

Sadly it is a configuration that is compiled with the assembly, and thus can't be modified at runtime. You are not the only one who came to me with this kind of request, so I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants