-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with remove owner having the wrong link #1604
base: master
Are you sure you want to change the base?
Conversation
Make sure to test adding and removing owners both through the GUI as well as through the API. The API is critical as once it is working we can add this to SBH2. |
On the GUI, I am not sure how to remove an owner. I can't seem to find the button. I did delete the ownedBy in the otherProperties, but when going to the second user, they were still able to access the part I shared. |
I did it through the API, and got a success, but when I went to the second user (test1) on the GUI, it still had access as well. I might be doing something wrong, but removeOwner doesn't appear to be working properly. |
Think I found the problem. Please re-test. |
Tested. Mostly working but still has a couple of bugs. |
Adding twice causes no issues. It would be difficult to remove from list, so I will leave this. The share link as we discussed does still work, but shared with me should not show it. Remove owner from API works, but the userUri needs to be the full user uri and not an id. This is indeed confusing in the API docs. |
Closes #1358
Closes #1357