-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SBOL 3->2: access is not set on ComponentInstance objects #20
Comments
Ah I know exactly why this is happening, and it wouldn’t have happened in earlier versions of sbolgraph so you wouldn’t have a fixup for it. Thanks for letting me know. |
I was just looking at restoring the previous behaviour of setting them all to public, but:
Should they not be set according to the SBOL3 Interface? Currently 2->3 conversion does not build SBOL3 Interface objects at all, but I will implement this as well. |
The SBOL3 In either case, |
Thanks - I was getting I'm looking at adding interfaces in 2->3 conversion. However, since interfaces are optional in SBOL3, I think these should only be created when necessary to capture the same intent as the SBOL2 representation. In order to accomplish this I need to establish what the absence of an interface in SBOL3 is equivalent to in SBOL2. Would it be the same as all |
Or to rephrase: if all of the |
I just found that we actually wrote more of this in the SBOL3 spec than I thought that we had! From page 51 of the 3.0.1 specification:
This makes me reverse my recommendation above, since that would not be able to round-trip correctly. I believe that this implies the SBOL3->2 conversion should be:
|
SBOL3 does not have a public/private access distinction, so all SBOL3 SubComponent objects that become SBOL2 Component or FunctionalComponent objects need to have their access set to
http://sbols.org/v2#public
. This is not currently happening.While correcting this, it is likely also a good idea to check if the 2->3 conversion is building SBOL3 Interface objects properly.
The text was updated successfully, but these errors were encountered: