Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all links and image references #90

Closed
PrashantVaidyanathan opened this issue Jan 19, 2021 · 15 comments · Fixed by #189
Closed

Check all links and image references #90

PrashantVaidyanathan opened this issue Jan 19, 2021 · 15 comments · Fixed by #189
Assignees

Comments

@PrashantVaidyanathan
Copy link
Contributor

PR #87 introduced a significant restructuring in the repository. Due to this some of the images and links do not show up anymore.

@jamesscottbrown
Copy link
Contributor

jamesscottbrown commented Feb 8, 2021

Some external sites are no longer available:

The community outrach and community meetings pages both have many broken links corresponding to past events. I don't know what these should link to. These should point at the corresponding files in https://github.com/SynBioDex/Community-Media

@Fontanapink
Copy link
Collaborator

Fixed the image issues with the last PR. The problem was that in wowchemy 5.0, the "static/img" folder had to be renamed to "static/media". Link: https://wowchemy.com/updates/v5.0.0-beta.0/#apply-breaking-changes

We should check for the other breaking chanches

@Fontanapink
Copy link
Collaborator

Also, we should check the image source location for the images that @hasanbaig changed on the SBOL Industrial Consortium page, and revert them back to the original reference.

@tcmitchell
Copy link
Contributor

I ran linkchecker on https://sbolstandard.org. It found 2 errors and took 7 minutes to run.

Summary:

Statistics:
Downloaded: 11.4MB.
Content types: 71 image, 658 text, 0 video, 0 audio, 463 application, 8 mail and 1055 other.
URL lengths: min=16, max=378, avg=81.

That's it. 2255 links in 2273 URLs checked. 0 warnings found. 2 errors found.
Stopped checking at 2022-04-06 11:24:13-004 (7 minutes, 6 seconds)

Error 1:

URL        `http://sbolstandard.org/combine-2017/'
Name       `Slides'
Parent URL https://sbolstandard.org/community-meetings/, line 20, col 3434
Real URL   https://sbolstandard.org/combine-2017/
Check time 3.040 seconds
Size       3KB
Info       Redirected to
           `https://sbolstandard.org/combine-2017/'.
Result     Error: 404 Not Found

Error 2:

URL        `Introduction to libSBOL and pySBOL'
Name       `Introduction to libSBOL and pySBOL'
Parent URL https://sbolstandard.org/event/2017/iwbda/, line 24, col 4279
Real URL   https://sbolstandard.org/event/2017/iwbda/Introduction%20to%20libSBOL%20and%20pySBOL
Check time 4.360 seconds
Size       3KB
Result     Error: 404 Not Found

The first will be easy to fix. For the second we'll have to see if we can find the presentation info.

@cjmyers
Copy link
Contributor

cjmyers commented Apr 6, 2022

@Fontanapink
Copy link
Collaborator

OK so there are a few different types of external links:

  1. For tools/software: I would remove external links pointing to software or tooling websites, as these may go down easily and we can't control it. Instead, most of these tools have publications. I would link to those
  2. some of the links posted here ARE links to publications. But some of them I can see them properly when clicked (like for example: https://www.pnas.org/content/109/18/7085 ). Does the link-checker tell you exactly where this link is located in the website?

@tcmitchell
Copy link
Contributor

Does the link-checker tell you exactly where this link is located in the website?

I have annotated the list above with the parent page links

@Fontanapink
Copy link
Collaborator

Thanks

@Fontanapink
Copy link
Collaborator

OK this link:

Still works when I click on it. I haven't tested the other.

@tcmitchell
Copy link
Contributor

Perhaps this is just a limitation of the linkchecker tool, and perhaps the web site is seeing too many requests from my IP address and is cutting me off temporarily. We can manually check these 10 links and those that work can be taken off the list. It's a small enough set to be manageable at this point.

@tcmitchell
Copy link
Contributor

I clicked all the links above, and update the list of broken links, which is now down to 8.

@cjmyers
Copy link
Contributor

cjmyers commented Apr 13, 2022

Fontanapink added a commit that referenced this issue Apr 13, 2022
this relates to issue #90
@tcmitchell
Copy link
Contributor

Here is the dispensation of each broken link:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants