Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBOL3/2 conversion of orientations #83

Closed
jakebeal opened this issue Jan 18, 2022 · 0 comments
Closed

SBOL3/2 conversion of orientations #83

jakebeal opened this issue Jan 18, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
1.0a15

Comments

@jakebeal
Copy link
Contributor

Conversion of Location object orientation fields between SBOL3 and SBOL2 does not work correctly currently, due to SynBioDex/sboljs3#16

A workaround has been tested in the iGEM distribution in iGEM-Engineering/iGEM-distribution@c1be614

This needs to be imported upstream to this library, cleaned up (orientations are currently remapped twice in the convert3to2 function) and needs to have tests added to validate that the conversion is working correctly.
@jakebeal jakebeal added bug Something isn't working good first issue Good for newcomers labels Jan 18, 2022
@Akshat-Kumar-0610 Akshat-Kumar-0610 mentioned this issue Jan 27, 2022
Merged
@jakebeal jakebeal added this to the 1.0a14 milestone Feb 6, 2022
@jakebeal jakebeal closed this as completed Feb 6, 2022
@jakebeal jakebeal modified the milestones: 1.0a14, 1.0a15 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
1.0a15
Development

No branches or pull requests
1 participant
@jakebeal