Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: vendor/superior/build/soong/Android.bp:24:8: module "generated_kernel_includes": cmd: unknown variable '$(PATH_OVERRIDE_SOONG)' #123

Open
VTVishwanath opened this issue Nov 14, 2023 · 2 comments

Comments

@VTVishwanath
Copy link

VTVishwanath commented Nov 14, 2023

I am building unofficially Superior OS for RMX1851 (Realme 3 Pro with sdm710 chipset). I am using thirteen branch.
Device tree used: https://github.com/VTVishwanath/superior_device_realme_RMX1851
Kernel tree used: https://github.com/Cykeek/kernel_realme_sdm710 -b A13 kernel/realme/sdm710
Device vendor tree used: https://github.com/ArrowOS-Devices/android_vendor_realme_RMX1851

I get below error.

[100% 1/1] analyzing Android.bp files and generating ninja file at /mnt/data/sos13/out/soong/build.ninja
FAILED: /mnt/data/sos13/out/soong/build.ninja
cd "$(dirname "/mnt/data/sos13/out/host/linux-x86/bin/soong_build")" && BUILDER="$PWD/$(basename "/mnt/data/sos13/out/host/linux-x86/bin/soong_bui
ld")" && cd / && env -i  "$BUILDER"     --top "$TOP"     --soong_out "/mnt/data/sos13/out/soong"     --out "/mnt/data/sos13/out"     -o /mnt/data/
sos13/out/soong/build.ninja --globListDir build --globFile /mnt/data/sos13/out/soong/globs-build.ninja -t -l /mnt/data/sos13/out/.module_paths/And
roid.bp.list --available_env /mnt/data/sos13/out/soong/soong.environment.available --used_env /mnt/data/sos13/out/soong/soong.environment.used.bui
ld Android.bp
error: vendor/superior/build/soong/Android.bp:24:8: module "generated_kernel_includes": cmd: unknown variable '$(PATH_OVERRIDE_SOONG)'
10:48:25 soong bootstrap failed with: exit status 1

#### failed to build some targets (36 seconds) ####

Raised this [PR] (#120) to solve this issue.
But after the code change made which is in the PR [I get another error.] (#122) So, reverted back the [PR] (#120).

Any idea how to fix this? Anyone faced this? What could be the root cause or fix?

@VTVishwanath
Copy link
Author

VTVishwanath commented Nov 14, 2023

Found this helpful, and Build is progressing after doing this. Not sure if its a legit method to solve it or not. Will keep posted here.

Translated text:

After checking, it should be (adapting to ginkgo):
device/xiaomi/ginkgo/mk_ginkgo.mk
Only include:
vendor/mokee/config/common_full_phone.mk

And PATH_OVERRIDE_SOONG is in:
vendor/mokee/config/BoardConfigSoong.mk
defined in.
vendor/mokee/config/BoardConfigMoKee.mk
will contain BoardConfigSoong, so try to put
BoardConfigMoKee added to
device/xiaomi/ginkgo/BoardConfig.mk
(Add include vendor/mokee/config/BoardConfigMoKee.mk at the bottom)

I found that aicp did not have this problem. After checking, it turned out to be:
$ grep -rn 'BoardConfigAicp'
build/make/core/config.mk:238:include vendor/aicp/config/BoardConfigAicp.mk

@wolverine2k
Copy link

@VTVishwanath Can you also provide the path to the repos in your comment of Nov 14? What should we set the PATH_OVERRIDE_SOONG to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants