Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError, when exporting an armature, that is not in the root, with collapse armatures enabled #89

Open
StjerneIdioten opened this issue Dec 22, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@StjerneIdioten
Copy link
Owner

StjerneIdioten commented Dec 22, 2020

In LXML elements can only have one parent, where in Element Tree they can belong to multiple. The exporter manually deletes elements after moving them to a different parent during skinned mesh export (when collapsing armature nodes), but if using LXML this will crash since it has already been moved by LXML itself. This will only happen if the armature to be exported is not a root node itself.

@StjerneIdioten StjerneIdioten added bug Something isn't working current focus The issue is currently being worked on labels Dec 22, 2020
@StjerneIdioten StjerneIdioten self-assigned this Dec 22, 2020
@StjerneIdioten StjerneIdioten changed the title ValueError when exporting skinned meshes and doing armature collapse ValueError, when exporting an armature, that is not in the root, with collapse armatures enabled Dec 22, 2020
@StjerneIdioten StjerneIdioten removed the current focus The issue is currently being worked on label Jan 15, 2021
@StjerneIdioten
Copy link
Owner Author

It seems to only be a problem if accidentally also selecting the armature itself (So a child of the root object), as when this happens using other object types the exporter merely duplicates the item. But for collapsed armature notes it crashes the exporter. So this seems more like a case of a badly handled "unexpected" user input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant