Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

코드 리팩토링 #165

Open
13 tasks
JeonDoGyun opened this issue Nov 7, 2023 · 0 comments
Open
13 tasks

코드 리팩토링 #165

JeonDoGyun opened this issue Nov 7, 2023 · 0 comments
Assignees
@JeonDoGyun

Comments

@JeonDoGyun
Copy link
Contributor

구현해야될 부분

  • 에러 캐칭 점검
  • 주석 달기
    • 함수, 이벤트 핸들러
    • 동작 방식에 추가적인 설명이 필요한 부분
  • 불필요한 console(), error(), alert() 제거 및 UI 로직으로 대체
  • 불필요한 import문 지우기

점검한 페이지

  • 로그인
  • 회원가입
  • 회원정보수정
  • 토큰검증레이아웃
  • 공통컴포넌트
  • 등록하기
  • 수정하기
@JeonDoGyun JeonDoGyun self-assigned this Nov 7, 2023
JeonDoGyun added a commit that referenced this issue Nov 7, 2023
@JeonDoGyun
Merge pull request #167 from Step3-kakao-tech-campus/feat/#165
ba668fe 
코드 리팩토링
JeonDoGyun added a commit that referenced this issue Nov 9, 2023
@JeonDoGyun
Merge branch 'develop' of https://github.com/Step3-kakao-tech-campus/…
2bdc281 
…Team16_FE into feat/#165
JeonDoGyun added a commit that referenced this issue Nov 9, 2023
@JeonDoGyun
Merge pull request #176 from Step3-kakao-tech-campus/feat/#165
dd897cf 
fix : json, slick parser 문제 해결
JeonDoGyun added a commit that referenced this issue Nov 10, 2023
@JeonDoGyun
Merge pull request #197 from Step3-kakao-tech-campus/feat/#165
9540937 
멘토링 내용 적용 - 에러캐칭, GNB 컨텐츠 노출 수정, meta og 속성 수정
JeonDoGyun added a commit that referenced this issue Nov 11, 2023
@JeonDoGyun
Merge pull request #202 from Step3-kakao-tech-campus/feat/#165
3899fbd 
fix: 회원가입 로더 문제 해결, Calendar Safari 브라우저 화면에서 부적절한 부분 해결
JeonDoGyun added a commit that referenced this issue Nov 11, 2023
@JeonDoGyun
Merge branch 'develop' of https://github.com/Step3-kakao-tech-campus/…
0651897 
…Team16_FE into feat/#165
JeonDoGyun added a commit that referenced this issue Nov 11, 2023
@JeonDoGyun
Merge pull request #203 from Step3-kakao-tech-campus/feat/#165
03a375e 
lazy loading 방식의 페이지에 Suspense 추가
JeonDoGyun added a commit that referenced this issue Nov 11, 2023
@JeonDoGyun
Merge branch 'develop' of https://github.com/Step3-kakao-tech-campus/…
0b622a3 
…Team16_FE into feat/#165
JeonDoGyun added a commit that referenced this issue Nov 11, 2023
@JeonDoGyun
Merge pull request #205 from Step3-kakao-tech-campus/feat/#165
08b68ad 
fix: 등록, 수정하기 api 문제
JeonDoGyun added a commit that referenced this issue Nov 11, 2023
@JeonDoGyun
Merge pull request #206 from Step3-kakao-tech-campus/feat/#165
0899eb9 
fix: ProfileList 페이지 경로 문제 해결
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeonDoGyun JeonDoGyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeonDoGyun