From fdafa8fca3f18bbd5e6f82c5db4f844b191af55d Mon Sep 17 00:00:00 2001 From: cbartondock Date: Tue, 28 Mar 2023 14:25:37 -0400 Subject: [PATCH] changelog --- CHANGELOG.md | 6 ++++++ src/renderer/components/ng-select.component.ts | 4 +++- src/renderer/modifiers/user-configuration.modifier.ts | 2 +- src/renderer/services/parsers.service.ts | 4 +--- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0f5c13b68b..b06b787581 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,12 @@ All notable changes to this project will be documented in this file. * [x] Automatic Preset Updating. * [x] Make icons work for Steam parser (with the caveat that they will most likely be overwritten when a developer updates their game). +## 2.3.47 +### Added +* Ability to exclude non-local artwork in exceptions (addresses [issue 398](https://github.com/SteamGridDB/steam-rom-manager/issues/398)) +### Fixed +* Image Provider resetting to SGDB even if none was previously selected ([issue 336](https://github.com/SteamGridDB/steam-rom-manager/issues/336)) + ## 2.3.46 ## Added * Ability to filter apps by parser title in addition to steam category. diff --git a/src/renderer/components/ng-select.component.ts b/src/renderer/components/ng-select.component.ts index ae677453f9..64cbfc05df 100644 --- a/src/renderer/components/ng-select.component.ts +++ b/src/renderer/components/ng-select.component.ts @@ -174,13 +174,15 @@ export class NgSelectComponent implements ControlValueAccessor { writeValue(value: any, suppressChanges: boolean = true): void { let optionIndex = this.getOptionId(value); - if (optionIndex !== -1) this.selectOption(optionIndex, false, suppressChanges); else if (value instanceof Array) { for (let i = 0; i < value.length; i++) { this.writeValue(value[i], suppressChanges); } + if(!value.length) { + this.clearOptions(); + } } else if (this.values.length==0 && value && value.title) { this.changeOptions([{ diff --git a/src/renderer/modifiers/user-configuration.modifier.ts b/src/renderer/modifiers/user-configuration.modifier.ts index e08625add0..9947144f77 100644 --- a/src/renderer/modifiers/user-configuration.modifier.ts +++ b/src/renderer/modifiers/user-configuration.modifier.ts @@ -8,7 +8,7 @@ let versionUp = (version: number) => { return version + 1 }; export const userConfiguration: ValidatorModifier = { controlProperty: 'version', - latestVersion: 12, + latestVersion: 13, fields: { undefined: { 'version': { method: () => 0 }, diff --git a/src/renderer/services/parsers.service.ts b/src/renderer/services/parsers.service.ts index 5349236239..40a316c5f9 100644 --- a/src/renderer/services/parsers.service.ts +++ b/src/renderer/services/parsers.service.ts @@ -524,11 +524,9 @@ export class ParsersService { }).then((data) => { let validatedConfigs: { saved: UserConfiguration, current: UserConfiguration }[] = []; let errorString: string = ''; - let updateNeeded: boolean = false; for (let i = 0; i < data.length; i++) { // TODO get rid of this ugly hack for making specified accounts mandatory for steam parser only data[i].userAccounts.specifiedAccounts = data[i].userAccounts.specifiedAccounts || ''; - updateNeeded=true; if(parserInfo.superTypesMap[data[i].parserType] !== parserInfo.ROMType) { data[i].titleFromVariable.tryToMatchTitle = false; data[i].executableModifier = "\"${exePath}\""; @@ -549,7 +547,7 @@ export class ParsersService { })); } this.userConfigurations.next(validatedConfigs); - if(updateNeeded) { + if(data.length) { this.saveUserConfigurations(); } }).catch((error) => {